reapply [llvm] add support for mustache templating language #130732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m-project into llvm-add-mustache
…m-project into llvm-add-mustache
…m-project into llvm-add-mustache
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
ilovepi
reviewed
Mar 11, 2025
llvm/lib/Support/Mustache.cpp
Outdated
| Lambdas = std::move(Other.Lambdas); | ||
| SectionLambdas = std::move(Other.SectionLambdas); | ||
| Escapes = std::move(Other.Escapes); | ||
| Tree = Other.Tree; |
There was a problem hiding this comment.
I think the bot gave a warning about the initialization order here, w.r.t. other members that are earlier in the class. I think that will go away if you move this down to just be fore you set Other.Tree=nullptr; Its just a warning, so not a huge deal, but it's trivial to change, and moves the logic for the Tree member into one place.
There was a problem hiding this comment.
I think the warning was with the move constructor on line 771. It wasn't ordered according to the declaration order so that was why it was throwing warnings
llvm/lib/Support/Mustache.cpp
Outdated
| std::string RawBody; | ||
| // TokenBody is the original string with the identifier removed. | ||
| std::string TokenBody; | ||
| Accessor Accessor; |
There was a problem hiding this comment.
wasn't this one of the things that broke on the GCC bot? I think this will still be an issue, no?
There was a problem hiding this comment.
Yea the issue was the naming conflict with the type alias Accessor which is declared in both Template and Token classes I renamed it.
|
Would you mind explaining what the delta is between this patch and the previous version? the PR says it fixes errors, but I'm not clear on what 's different, precisely. |
I've updated the issue |
ilovepi
approved these changes
Mar 11, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/51/builds/12367 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/168/builds/9624 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/55/builds/8284 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/186/builds/7234 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/72/builds/9070 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/145/builds/5608 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/169/builds/9327 Here is the relevant piece of the build log for the reference |
PeterChou1
added a commit
that referenced
this pull request
Mar 12, 2025
Reapply #130732 Fixes errors which broke build bot that uses GCC as a compiler https://lab.llvm.org/buildbot/#/builders/66/builds/11049 GCC threw an warning due to an issue std::move with a temporary object which prevents copy elision. Fixes the issue by removing the std::move Adds Support for the Mustache Templating Language. See specs here: https://mustache.github.io/mustache.5.html This patch implements support+tests for majority of the features of the language including: - Variables - Comments - Lambdas - Sections This meant as a library to support places where we have to generate HTML, such as in clang-doc.
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Mar 12, 2025
…e (#130876) Reapply llvm/llvm-project#130732 Fixes errors which broke build bot that uses GCC as a compiler https://lab.llvm.org/buildbot/#/builders/66/builds/11049 GCC threw an warning due to an issue std::move with a temporary object which prevents copy elision. Fixes the issue by removing the std::move Adds Support for the Mustache Templating Language. See specs here: https://mustache.github.io/mustache.5.html This patch implements support+tests for majority of the features of the language including: - Variables - Comments - Lambdas - Sections This meant as a library to support places where we have to generate HTML, such as in clang-doc.
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/146/builds/2472 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/64/builds/2482 Here is the relevant piece of the build log for the reference |
frederik-h
pushed a commit
to frederik-h/llvm-project
that referenced
this pull request
Mar 18, 2025
) Reapply llvm#130732 Fixes errors which broke build bot that uses GCC as a compiler https://lab.llvm.org/buildbot/#/builders/66/builds/11049 GCC threw an warning due to an issue std::move with a temporary object which prevents copy elision. Fixes the issue by removing the std::move Adds Support for the Mustache Templating Language. See specs here: https://mustache.github.io/mustache.5.html This patch implements support+tests for majority of the features of the language including: - Variables - Comments - Lambdas - Sections This meant as a library to support places where we have to generate HTML, such as in clang-doc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reapply #105893
Fixes errors which broke build bot that uses GCC as a compiler
https://lab.llvm.org/buildbot/#/builders/136/builds/3100
The issue here was that using Accessor defined in the anonymous namespace introduces Accessor as a type alias. Which is, later redeclare as members in classes Token and ASTNode with the same name which causes error in GCC. The patch fixes it by renaming the Accesor to AccessorValue. It also fixes warnings caused by the compile due to initialization
Adds Support for the Mustache Templating Language. See specs here: https://mustache.github.io/mustache.5.html
This patch implements support+tests for majority of the features of the language including:
This meant as a library to support places where we have to generate HTML, such as in clang-doc.