Skip to content

[Security] Nominate Matthew Voss to replace Paul Robinson on the Secu… #106112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

pogo59
Copy link
Collaborator

@pogo59 pogo59 commented Aug 26, 2024

…rity Group

Matthew is a member of Sony's PS4/PS5 toolchain team, most visible for his work on LTO, but he also has a long-standing interest in security. He will replace Paul as one of Sony's participants in the Security Group as Paul will be retiring from Sony at the end of September.

…rity Group

Matthew is a member of Sony's PS4/PS5 toolchain team, most visible for
his work on LTO, but he also has a long-standing interest in security.
He will replace Paul as one of Sony's participants in the Security
Group as Paul will be retiring from Sony at the end of September.
@tuliom
Copy link
Contributor

tuliom commented Aug 26, 2024

I'm not sure if there is a goal to keep the list of names sorted, but this change is breaking it.

@pogo59
Copy link
Collaborator Author

pogo59 commented Aug 26, 2024

It didn't look sorted, but now I look again it is sorted by first name. I'll update.

Copy link
Collaborator

@smithp35 smithp35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator Author

@pogo59 pogo59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the list of members, we have 20 (not including me), so we need 10 approvals, but not everyone could be added as a reviewer.

Members whom "at" can find: @ojhunt @pietroalbini @tpenge
Members whom "at" cannot find: @mmdriley @GreatKeeper @wpuhn-intel
Members with no GH handle listed: Artur Pilipenko, Nikhil Gupta

@tuliom
Copy link
Contributor

tuliom commented Aug 27, 2024

I created PR #106255 in order to automate the step that asks for reviewers.
It should also solve the issue that @pogo59 mentioned in the last comment.

@pogo59
Copy link
Collaborator Author

pogo59 commented Aug 29, 2024

Maybe it's early to ping, but I count 9 different approvals and we need 10 to reach the 50% mark. (@tuliom LGTM'd twice but the voting integrity coordinator has rejected the duplicate.)

Copy link
Collaborator

@DimitryAndric DimitryAndric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pogo59 pogo59 merged commit 1faa9c8 into llvm:main Aug 30, 2024
7 of 9 checks passed
@pogo59
Copy link
Collaborator Author

pogo59 commented Aug 30, 2024

Thanks everyone!

@kbeyls we need to get @ormris aka [email protected] added to all the right lists, teams, whatever.

@kbeyls
Copy link
Collaborator

kbeyls commented Sep 2, 2024

Thanks everyone!

@kbeyls we need to get @ormris aka [email protected] added to all the right lists, teams, whatever.

I've just invited @ormris to the @llvm/llvm-security-group github team to get access to the "security issues reported privately", and to the security teams internal mailing list. @ormris: if anything is unclear about the invites you receive, please do ping me directly. If possible, also please do try to attend the monthly public LLVM security group sync-ups, see https://discourse.llvm.org/t/llvm-security-group-public-sync-ups/62735.

@ormris
Copy link
Collaborator

ormris commented Sep 4, 2024

Thanks! Will do.

@pogo59 pogo59 deleted the voss-security-group branch October 3, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.