-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[github][Security] Add the llvm-security-group team as code owner for Security.rst #106255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… Security.rst This will help to notify all the LLVM Security Group when pull requests to the documentation are created.
This should also help to solve the issue mentioned in #106112 (review) The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diff warns with:
Unknown owner on line 155: make sure the team @llvm/llvm-security-group exists, is publicly visible, and has write access to the repository
It exists and seems visible, so I assume that's another symptom of what you were discussing in #106112, namely that some of the members don't have write access?
I don't know how github will behave. If it adds everyone else, I suppose that's better than today's situation, so I'm happy to give this a try; LGTM!
I don't think the group is publicly visible -- in a private window, I'm prompted to log in first. |
The same thing happens with other teams, e.g. reviewers-libcxx . |
Acording to this document, a visible team can be viewed and mentioned by every organization member. The problem might be related to not having write access. |
The group should be public, see this screenshot from the team settings I just took (not sure in how far others have access to seeing these settings): ![]() |
I think that's still not visible outside the org, but I have no idea how to open that up further. Or it may just be write access. I dropped my own write access because I felt that sending PRs was enough for me, but I guess I could get it back if that's important here. |
Unfortunately this proposal is not going to work, because it requires to give write access to the team. Thanks @tstellar ! If nobody objects to this new proposal, I will update this PR in the following days. |
This will help to notify all the LLVM Security Group when pull requests to the documentation are created.