Skip to content

[github][Security] Add the llvm-security-group team as code owner for Security.rst #106255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tuliom
Copy link
Contributor

@tuliom tuliom commented Aug 27, 2024

This will help to notify all the LLVM Security Group when pull requests to the documentation are created.

… Security.rst

This will help to notify all the LLVM Security Group when pull requests
to the documentation are created.
@tuliom
Copy link
Contributor Author

tuliom commented Aug 27, 2024

This should also help to solve the issue mentioned in #106112 (review)

The llvm/llvm-security-group is larger than the Github limit for reviewers (15), making it impossible to add everybody.

Copy link
Member

@ahmedbougacha ahmedbougacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff warns with:

Unknown owner on line 155: make sure the team @llvm/llvm-security-group exists, is publicly visible, and has write access to the repository

It exists and seems visible, so I assume that's another symptom of what you were discussing in #106112, namely that some of the members don't have write access?
I don't know how github will behave. If it adds everyone else, I suppose that's better than today's situation, so I'm happy to give this a try; LGTM!

@cuviper
Copy link
Member

cuviper commented Aug 27, 2024

I don't think the group is publicly visible -- in a private window, I'm prompted to log in first.

@tuliom
Copy link
Contributor Author

tuliom commented Aug 27, 2024

I don't think the group is publicly visible -- in a private window, I'm prompted to log in first.

The same thing happens with other teams, e.g. reviewers-libcxx .
I wonder if @kbeyls can see the settings of the group.

@tuliom
Copy link
Contributor Author

tuliom commented Aug 27, 2024

Acording to this document, a visible team can be viewed and mentioned by every organization member.
Secret teams get a "Secret" label that members can see.
I don't see this label in the llvm-security-group team.

The problem might be related to not having write access.

@kbeyls
Copy link
Collaborator

kbeyls commented Aug 27, 2024

I don't think the group is publicly visible -- in a private window, I'm prompted to log in first.

The same thing happens with other teams, e.g. reviewers-libcxx . I wonder if @kbeyls can see the settings of the group.

The group should be public, see this screenshot from the team settings I just took (not sure in how far others have access to seeing these settings):

Screenshot 2024-08-27 at 21 38 51

@cuviper
Copy link
Member

cuviper commented Aug 27, 2024

I think that's still not visible outside the org, but I have no idea how to open that up further.

Or it may just be write access. I dropped my own write access because I felt that sending PRs was enough for me, but I guess I could get it back if that's important here.

@tuliom
Copy link
Contributor Author

tuliom commented Aug 29, 2024

Unfortunately this proposal is not going to work, because it requires to give write access to the team. Thanks @tstellar !
He also suggested that we create a pr-subscribers team. This kind of team is automatically mentioned in the PR. Notice the team is not added as reviewer. But it has the positive side of making write permission more complex by adding yet another team with write permission.

If nobody objects to this new proposal, I will update this PR in the following days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants