-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[AMDGPU][Docs] Update product names for some targets #106973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
@llvm/pr-subscribers-backend-amdgpu Author: Aarni Koskela (akx) ChangesFull diff: https://github.com/llvm/llvm-project/pull/106973.diff 1 Files Affected:
diff --git a/llvm/docs/AMDGPUUsage.rst b/llvm/docs/AMDGPUUsage.rst
index 80140734cbefd6..a5ad3f6bbf7b2b 100644
--- a/llvm/docs/AMDGPUUsage.rst
+++ b/llvm/docs/AMDGPUUsage.rst
@@ -392,12 +392,12 @@ Every processor supports every OS ABI (see :ref:`amdgpu-os`) with the following
work-item Add product
IDs names.
- ``gfx942`` ``amdgcn`` dGPU - sramecc - Architected *TBA*
- - tgsplit flat
- - xnack scratch .. TODO::
+ ``gfx942`` ``amdgcn`` dGPU - sramecc - Architected - AMD Instinct MI300X
+ - tgsplit flat - AMD Instinct MI300A
+ - xnack scratch
- kernarg preload - Packed
- work-item Add product
- IDs names.
+ work-item
+ IDs
**GCN GFX10.1 (RDNA 1)** [AMD-GCN-GFX10-RDNA1]_
-----------------------------------------------------------------------------------------------------------------------
@@ -424,6 +424,8 @@ Every processor supports every OS ABI (see :ref:`amdgpu-os`) with the following
``gfx1030`` ``amdgcn`` dGPU - cumode - Absolute - *rocm-amdhsa* - Radeon RX 6800
- wavefrontsize64 flat - *pal-amdhsa* - Radeon RX 6800 XT
scratch - *pal-amdpal* - Radeon RX 6900 XT
+ - Radeon PRO W6800
+ - Radeon PRO V620
``gfx1031`` ``amdgcn`` dGPU - cumode - Absolute - *rocm-amdhsa* - Radeon RX 6700 XT
- wavefrontsize64 flat - *pal-amdhsa*
scratch - *pal-amdpal*
@@ -462,12 +464,12 @@ Every processor supports every OS ABI (see :ref:`amdgpu-os`) with the following
**GCN GFX11 (RDNA 3)** [AMD-GCN-GFX11-RDNA3]_
-----------------------------------------------------------------------------------------------------------------------
- ``gfx1100`` ``amdgcn`` dGPU - cumode - Architected - *pal-amdpal* *TBA*
- - wavefrontsize64 flat
- scratch .. TODO::
- - Packed
- work-item Add product
- IDs names.
+ ``gfx1100`` ``amdgcn`` dGPU - cumode - Architected - *pal-amdpal* - Radeon PRO W7900 Dual Slot
+ - wavefrontsize64 flat - Radeon PRO W7900
+ scratch - Radeon PRO W7800
+ - Packed - Radeon RX 7900 XTX
+ work-item - Radeon RX 7900 XT
+ IDs - Radeon RX 7900 GRE
``gfx1101`` ``amdgcn`` dGPU - cumode - Architected *TBA*
- wavefrontsize64 flat
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me!
How do we move this forward? 😅 |
@akx Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR. Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues. How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
Based on https://rocm.docs.amd.com/projects/install-on-linux/en/latest/reference/system-requirements.html#supported-gpus.