Add target-byteorder for cases where endian in target triple is what matters #107915

perry-ca · 2024-09-09T21:14:41Z

I came across the subtly when setting up lit for z/OS and running it on a Linux on Power machine. Linux on Power is little endian. This was resulting in all of these tests being run even though the target triple was z/OS which is big endian. The lit should really be checking if the target is little endian not the host. The previous way didn't handle cross compilation while running lit.

llvmbot · 2024-09-09T21:15:17Z

@llvm/pr-subscribers-debuginfo

Author: Sean Perry (perry-ca)

Changes

I came across the subtly when setting up lit for z/OS and running it on a Linux on Power machine. Linux on Power is little endian. This was resulting in all of these tests being run even though the target triple was z/OS which is big endian. The lit should really be checking if the target is little endian not the host. The previous way didn't handle cross compilation while running lit.

Full diff: https://github.com/llvm/llvm-project/pull/107915.diff

12 Files Affected:

(modified) llvm/test/CodeGen/Generic/allow-check.ll (+1-1)
(modified) llvm/test/Object/AArch64/chained-fixups-header.test (+1-1)
(modified) llvm/test/Object/AArch64/filetype-fileset.yaml (+1-1)
(modified) llvm/test/lit.cfg.py (+4-1)
(modified) llvm/test/tools/dsymutil/X86/reflection-dump.test (+1-1)
(modified) llvm/test/tools/sancov/covered_functions.test (+1-1)
(modified) llvm/test/tools/sancov/ignorelist.test (+1-1)
(modified) llvm/test/tools/sancov/not_covered_functions.test (+1-1)
(modified) llvm/test/tools/sancov/print.test (+1-1)
(modified) llvm/test/tools/sancov/stats.test (+1-1)
(modified) llvm/test/tools/sancov/symbolize.test (+1-1)
(modified) llvm/test/tools/sancov/symbolize_noskip_dead_files.test (+1-1)

diff --git a/llvm/test/CodeGen/Generic/allow-check.ll b/llvm/test/CodeGen/Generic/allow-check.ll
index a08488959862ab..148ee811ea806c 100644
--- a/llvm/test/CodeGen/Generic/allow-check.ll
+++ b/llvm/test/CodeGen/Generic/allow-check.ll
@@ -1,5 +1,5 @@
 ; Avoid `!DL->isLittleEndian() && !CLI->enableBigEndian()` missmatch on PPC64BE.
-; REQUIRES: host-byteorder-little-endian
+; REQUIRES: target-byteorder-little-endian
 
 ; -global-isel=1 is unsupported.
 ; XFAIL: target=loongarch{{.*}}
diff --git a/llvm/test/Object/AArch64/chained-fixups-header.test b/llvm/test/Object/AArch64/chained-fixups-header.test
index 5bdf07a56d3609..409c1222ffa39f 100644
--- a/llvm/test/Object/AArch64/chained-fixups-header.test
+++ b/llvm/test/Object/AArch64/chained-fixups-header.test
@@ -1,4 +1,4 @@
-REQUIRES: host-byteorder-little-endian
+REQUIRES: target-byteorder-little-endian
 RUN: cat %p/../Inputs/MachO/chained-fixups.yaml \
 RUN:   | sed 's/__LINKEDIT:      00000000/__LINKEDIT:      AB000000/' \
 RUN:   | yaml2obj | not llvm-objdump --macho --dyld-info - 2>&1 \
diff --git a/llvm/test/Object/AArch64/filetype-fileset.yaml b/llvm/test/Object/AArch64/filetype-fileset.yaml
index 0f9631ff076b2f..73bb2e01db43fb 100644
--- a/llvm/test/Object/AArch64/filetype-fileset.yaml
+++ b/llvm/test/Object/AArch64/filetype-fileset.yaml
@@ -1,4 +1,4 @@
-# REQUIRES: host-byteorder-little-endian
+# REQUIRES: target-byteorder-little-endian
 # RUN: yaml2obj %s \
 # RUN:   | llvm-objdump --macho --private-header - 2>&1 \
 # RUN:   | FileCheck %s
diff --git a/llvm/test/lit.cfg.py b/llvm/test/lit.cfg.py
index 1e0dd0a7df34f1..cff6dc962e98be 100644
--- a/llvm/test/lit.cfg.py
+++ b/llvm/test/lit.cfg.py
@@ -363,7 +363,10 @@ def version_int(ver):
 ):
     config.available_features.add("llvm-64-bits")
 
-config.available_features.add("host-byteorder-" + sys.byteorder + "-endian")
+if re.match(r"(aarch64_be|arc|armeb|bpfeb|lanai|m68k|mips|mips64|powerpc|powerpc64|sparc|sparcv9|s390x|s390|tce|thumbeb)-.*", config.target_triple):
+    config.available_features.add("target-byteorder-big-endian")
+else:
+    config.available_features.add("target-byteorder-little-endian")
 
 if sys.platform in ["win32"]:
     # ExecutionEngine, no weak symbols in COFF.
diff --git a/llvm/test/tools/dsymutil/X86/reflection-dump.test b/llvm/test/tools/dsymutil/X86/reflection-dump.test
index 9cf9874f4acddd..dc58d399596145 100644
--- a/llvm/test/tools/dsymutil/X86/reflection-dump.test
+++ b/llvm/test/tools/dsymutil/X86/reflection-dump.test
@@ -12,7 +12,7 @@ RUN: llvm-objdump -s %t.dir/main.dSYM/Contents/Resources/DWARF/main | FileCheck
 RUN: dsymutil --linker parallel -oso-prepend-path=%t.dir %t.dir/main -o %t.dir/main.dSYM
 RUN: llvm-objdump -s %t.dir/main.dSYM/Contents/Resources/DWARF/main | FileCheck %s
 
-REQUIRES: host-byteorder-little-endian
+REQUIRES: target-byteorder-little-endian
 
 
 CHECK: Contents of section __DWARF,__swift5_assocty:
diff --git a/llvm/test/tools/sancov/covered_functions.test b/llvm/test/tools/sancov/covered_functions.test
index bcdfaf8879d41a..bca37bb7bdf878 100644
--- a/llvm/test/tools/sancov/covered_functions.test
+++ b/llvm/test/tools/sancov/covered_functions.test
@@ -1,4 +1,4 @@
-REQUIRES: x86-registered-target && host-byteorder-little-endian
+REQUIRES: x86-registered-target && target-byteorder-little-endian
 RUN: sancov -covered-functions %p/Inputs/test-linux_x86_64 %p/Inputs/test-linux_x86_64.0.sancov | FileCheck %s
 RUN: sancov -covered-functions -strip_path_prefix=Inputs/ %p/Inputs/test-linux_x86_64 %p/Inputs/test-linux_x86_64.0.sancov | FileCheck --check-prefix=STRIP_PATH %s
 RUN: sancov -demangle=0 -covered-functions %p/Inputs/test-linux_x86_64 %p/Inputs/test-linux_x86_64.0.sancov | FileCheck --check-prefix=NO_DEMANGLE %s
diff --git a/llvm/test/tools/sancov/ignorelist.test b/llvm/test/tools/sancov/ignorelist.test
index 01d03aed05b237..0456b9b0dc1ded 100644
--- a/llvm/test/tools/sancov/ignorelist.test
+++ b/llvm/test/tools/sancov/ignorelist.test
@@ -1,4 +1,4 @@
-REQUIRES: x86-registered-target && host-byteorder-little-endian
+REQUIRES: x86-registered-target && target-byteorder-little-endian
 RUN: sancov -covered-functions %p/Inputs/test-linux_x86_64 %p/Inputs/test-linux_x86_64.0.sancov | FileCheck %s --check-prefix=ALL
 RUN: sancov -covered-functions -ignorelist %p/Inputs/fun_ignorelist.txt %p/Inputs/test-linux_x86_64 %p/Inputs/test-linux_x86_64.0.sancov | FileCheck %s
 RUN: sancov -covered-functions -ignorelist %p/Inputs/src_ignorelist.txt %p/Inputs/test-linux_x86_64 %p/Inputs/test-linux_x86_64.1.sancov | FileCheck --check-prefix=CHECK1 %s
diff --git a/llvm/test/tools/sancov/not_covered_functions.test b/llvm/test/tools/sancov/not_covered_functions.test
index d1b91f6e56820a..54541bbcb124bb 100644
--- a/llvm/test/tools/sancov/not_covered_functions.test
+++ b/llvm/test/tools/sancov/not_covered_functions.test
@@ -1,4 +1,4 @@
-REQUIRES: x86-registered-target && host-byteorder-little-endian
+REQUIRES: x86-registered-target && target-byteorder-little-endian
 RUN: sancov -skip-dead-files=0 -not-covered-functions %p/Inputs/test-linux_x86_64 %p/Inputs/test-linux_x86_64.0.sancov | FileCheck %s
 RUN: sancov -not-covered-functions %p/Inputs/test-linux_x86_64 %p/Inputs/test-linux_x86_64.1.sancov | FileCheck --check-prefix=CHECK1 --allow-empty %s
 
diff --git a/llvm/test/tools/sancov/print.test b/llvm/test/tools/sancov/print.test
index 62ab3d991b8e3c..26bbf47f4d987e 100644
--- a/llvm/test/tools/sancov/print.test
+++ b/llvm/test/tools/sancov/print.test
@@ -1,4 +1,4 @@
-REQUIRES: x86-registered-target && host-byteorder-little-endian
+REQUIRES: x86-registered-target && target-byteorder-little-endian
 RUN: sancov -print %p/Inputs/test-linux_x86_64.0.sancov | FileCheck %s
 
 CHECK: 0x4e132b
diff --git a/llvm/test/tools/sancov/stats.test b/llvm/test/tools/sancov/stats.test
index 46ff6e5e5db10e..1777a6d04fed74 100644
--- a/llvm/test/tools/sancov/stats.test
+++ b/llvm/test/tools/sancov/stats.test
@@ -1,4 +1,4 @@
-REQUIRES: x86-registered-target && host-byteorder-little-endian
+REQUIRES: x86-registered-target && target-byteorder-little-endian
 RUN: sancov -print-coverage-stats %p/Inputs/test-linux_x86_64 %p/Inputs/test-linux_x86_64.0.sancov | FileCheck %s
 
 CHECK: all-edges: 8
diff --git a/llvm/test/tools/sancov/symbolize.test b/llvm/test/tools/sancov/symbolize.test
index acf58ae1171238..4ffafb7448815f 100644
--- a/llvm/test/tools/sancov/symbolize.test
+++ b/llvm/test/tools/sancov/symbolize.test
@@ -1,4 +1,4 @@
-REQUIRES: x86-registered-target && host-byteorder-little-endian
+REQUIRES: x86-registered-target && target-byteorder-little-endian
 RUN: sancov -symbolize -strip_path_prefix="llvm/" %p/Inputs/test-linux_x86_64 %p/Inputs/test-linux_x86_64.0.sancov | FileCheck %s --check-prefixes=CHECK,STRIP
 RUN: sancov -symbolize %p/Inputs/test-linux_x86_64 %p/Inputs/test-linux_x86_64.0.sancov | FileCheck %s --check-prefixes=CHECK,NOSTRIP
 
diff --git a/llvm/test/tools/sancov/symbolize_noskip_dead_files.test b/llvm/test/tools/sancov/symbolize_noskip_dead_files.test
index 0038ea197735aa..e366bdcb2ef75f 100644
--- a/llvm/test/tools/sancov/symbolize_noskip_dead_files.test
+++ b/llvm/test/tools/sancov/symbolize_noskip_dead_files.test
@@ -1,4 +1,4 @@
-REQUIRES: x86-registered-target && host-byteorder-little-endian
+REQUIRES: x86-registered-target && target-byteorder-little-endian
 RUN: sancov -symbolize -skip-dead-files=0 -strip_path_prefix="llvm/" %p/Inputs/test-linux_x86_64 %p/Inputs/test-linux_x86_64.0.sancov | FileCheck %s
 
 CHECK: {

llvmbot · 2024-09-09T21:15:17Z

@llvm/pr-subscribers-llvm-binary-utilities

Author: Sean Perry (perry-ca)

Changes

I came across the subtly when setting up lit for z/OS and running it on a Linux on Power machine. Linux on Power is little endian. This was resulting in all of these tests being run even though the target triple was z/OS which is big endian. The lit should really be checking if the target is little endian not the host. The previous way didn't handle cross compilation while running lit.

Full diff: https://github.com/llvm/llvm-project/pull/107915.diff

12 Files Affected:

(modified) llvm/test/CodeGen/Generic/allow-check.ll (+1-1)
(modified) llvm/test/Object/AArch64/chained-fixups-header.test (+1-1)
(modified) llvm/test/Object/AArch64/filetype-fileset.yaml (+1-1)
(modified) llvm/test/lit.cfg.py (+4-1)
(modified) llvm/test/tools/dsymutil/X86/reflection-dump.test (+1-1)
(modified) llvm/test/tools/sancov/covered_functions.test (+1-1)
(modified) llvm/test/tools/sancov/ignorelist.test (+1-1)
(modified) llvm/test/tools/sancov/not_covered_functions.test (+1-1)
(modified) llvm/test/tools/sancov/print.test (+1-1)
(modified) llvm/test/tools/sancov/stats.test (+1-1)
(modified) llvm/test/tools/sancov/symbolize.test (+1-1)
(modified) llvm/test/tools/sancov/symbolize_noskip_dead_files.test (+1-1)

diff --git a/llvm/test/CodeGen/Generic/allow-check.ll b/llvm/test/CodeGen/Generic/allow-check.ll
index a08488959862ab..148ee811ea806c 100644
--- a/llvm/test/CodeGen/Generic/allow-check.ll
+++ b/llvm/test/CodeGen/Generic/allow-check.ll
@@ -1,5 +1,5 @@
 ; Avoid `!DL->isLittleEndian() && !CLI->enableBigEndian()` missmatch on PPC64BE.
-; REQUIRES: host-byteorder-little-endian
+; REQUIRES: target-byteorder-little-endian
 
 ; -global-isel=1 is unsupported.
 ; XFAIL: target=loongarch{{.*}}
diff --git a/llvm/test/Object/AArch64/chained-fixups-header.test b/llvm/test/Object/AArch64/chained-fixups-header.test
index 5bdf07a56d3609..409c1222ffa39f 100644
--- a/llvm/test/Object/AArch64/chained-fixups-header.test
+++ b/llvm/test/Object/AArch64/chained-fixups-header.test
@@ -1,4 +1,4 @@
-REQUIRES: host-byteorder-little-endian
+REQUIRES: target-byteorder-little-endian
 RUN: cat %p/../Inputs/MachO/chained-fixups.yaml \
 RUN:   | sed 's/__LINKEDIT:      00000000/__LINKEDIT:      AB000000/' \
 RUN:   | yaml2obj | not llvm-objdump --macho --dyld-info - 2>&1 \
diff --git a/llvm/test/Object/AArch64/filetype-fileset.yaml b/llvm/test/Object/AArch64/filetype-fileset.yaml
index 0f9631ff076b2f..73bb2e01db43fb 100644
--- a/llvm/test/Object/AArch64/filetype-fileset.yaml
+++ b/llvm/test/Object/AArch64/filetype-fileset.yaml
@@ -1,4 +1,4 @@
-# REQUIRES: host-byteorder-little-endian
+# REQUIRES: target-byteorder-little-endian
 # RUN: yaml2obj %s \
 # RUN:   | llvm-objdump --macho --private-header - 2>&1 \
 # RUN:   | FileCheck %s
diff --git a/llvm/test/lit.cfg.py b/llvm/test/lit.cfg.py
index 1e0dd0a7df34f1..cff6dc962e98be 100644
--- a/llvm/test/lit.cfg.py
+++ b/llvm/test/lit.cfg.py
@@ -363,7 +363,10 @@ def version_int(ver):
 ):
     config.available_features.add("llvm-64-bits")
 
-config.available_features.add("host-byteorder-" + sys.byteorder + "-endian")
+if re.match(r"(aarch64_be|arc|armeb|bpfeb|lanai|m68k|mips|mips64|powerpc|powerpc64|sparc|sparcv9|s390x|s390|tce|thumbeb)-.*", config.target_triple):
+    config.available_features.add("target-byteorder-big-endian")
+else:
+    config.available_features.add("target-byteorder-little-endian")
 
 if sys.platform in ["win32"]:
     # ExecutionEngine, no weak symbols in COFF.
diff --git a/llvm/test/tools/dsymutil/X86/reflection-dump.test b/llvm/test/tools/dsymutil/X86/reflection-dump.test
index 9cf9874f4acddd..dc58d399596145 100644
--- a/llvm/test/tools/dsymutil/X86/reflection-dump.test
+++ b/llvm/test/tools/dsymutil/X86/reflection-dump.test
@@ -12,7 +12,7 @@ RUN: llvm-objdump -s %t.dir/main.dSYM/Contents/Resources/DWARF/main | FileCheck
 RUN: dsymutil --linker parallel -oso-prepend-path=%t.dir %t.dir/main -o %t.dir/main.dSYM
 RUN: llvm-objdump -s %t.dir/main.dSYM/Contents/Resources/DWARF/main | FileCheck %s
 
-REQUIRES: host-byteorder-little-endian
+REQUIRES: target-byteorder-little-endian
 
 
 CHECK: Contents of section __DWARF,__swift5_assocty:
diff --git a/llvm/test/tools/sancov/covered_functions.test b/llvm/test/tools/sancov/covered_functions.test
index bcdfaf8879d41a..bca37bb7bdf878 100644
--- a/llvm/test/tools/sancov/covered_functions.test
+++ b/llvm/test/tools/sancov/covered_functions.test
@@ -1,4 +1,4 @@
-REQUIRES: x86-registered-target && host-byteorder-little-endian
+REQUIRES: x86-registered-target && target-byteorder-little-endian
 RUN: sancov -covered-functions %p/Inputs/test-linux_x86_64 %p/Inputs/test-linux_x86_64.0.sancov | FileCheck %s
 RUN: sancov -covered-functions -strip_path_prefix=Inputs/ %p/Inputs/test-linux_x86_64 %p/Inputs/test-linux_x86_64.0.sancov | FileCheck --check-prefix=STRIP_PATH %s
 RUN: sancov -demangle=0 -covered-functions %p/Inputs/test-linux_x86_64 %p/Inputs/test-linux_x86_64.0.sancov | FileCheck --check-prefix=NO_DEMANGLE %s
diff --git a/llvm/test/tools/sancov/ignorelist.test b/llvm/test/tools/sancov/ignorelist.test
index 01d03aed05b237..0456b9b0dc1ded 100644
--- a/llvm/test/tools/sancov/ignorelist.test
+++ b/llvm/test/tools/sancov/ignorelist.test
@@ -1,4 +1,4 @@
-REQUIRES: x86-registered-target && host-byteorder-little-endian
+REQUIRES: x86-registered-target && target-byteorder-little-endian
 RUN: sancov -covered-functions %p/Inputs/test-linux_x86_64 %p/Inputs/test-linux_x86_64.0.sancov | FileCheck %s --check-prefix=ALL
 RUN: sancov -covered-functions -ignorelist %p/Inputs/fun_ignorelist.txt %p/Inputs/test-linux_x86_64 %p/Inputs/test-linux_x86_64.0.sancov | FileCheck %s
 RUN: sancov -covered-functions -ignorelist %p/Inputs/src_ignorelist.txt %p/Inputs/test-linux_x86_64 %p/Inputs/test-linux_x86_64.1.sancov | FileCheck --check-prefix=CHECK1 %s
diff --git a/llvm/test/tools/sancov/not_covered_functions.test b/llvm/test/tools/sancov/not_covered_functions.test
index d1b91f6e56820a..54541bbcb124bb 100644
--- a/llvm/test/tools/sancov/not_covered_functions.test
+++ b/llvm/test/tools/sancov/not_covered_functions.test
@@ -1,4 +1,4 @@
-REQUIRES: x86-registered-target && host-byteorder-little-endian
+REQUIRES: x86-registered-target && target-byteorder-little-endian
 RUN: sancov -skip-dead-files=0 -not-covered-functions %p/Inputs/test-linux_x86_64 %p/Inputs/test-linux_x86_64.0.sancov | FileCheck %s
 RUN: sancov -not-covered-functions %p/Inputs/test-linux_x86_64 %p/Inputs/test-linux_x86_64.1.sancov | FileCheck --check-prefix=CHECK1 --allow-empty %s
 
diff --git a/llvm/test/tools/sancov/print.test b/llvm/test/tools/sancov/print.test
index 62ab3d991b8e3c..26bbf47f4d987e 100644
--- a/llvm/test/tools/sancov/print.test
+++ b/llvm/test/tools/sancov/print.test
@@ -1,4 +1,4 @@
-REQUIRES: x86-registered-target && host-byteorder-little-endian
+REQUIRES: x86-registered-target && target-byteorder-little-endian
 RUN: sancov -print %p/Inputs/test-linux_x86_64.0.sancov | FileCheck %s
 
 CHECK: 0x4e132b
diff --git a/llvm/test/tools/sancov/stats.test b/llvm/test/tools/sancov/stats.test
index 46ff6e5e5db10e..1777a6d04fed74 100644
--- a/llvm/test/tools/sancov/stats.test
+++ b/llvm/test/tools/sancov/stats.test
@@ -1,4 +1,4 @@
-REQUIRES: x86-registered-target && host-byteorder-little-endian
+REQUIRES: x86-registered-target && target-byteorder-little-endian
 RUN: sancov -print-coverage-stats %p/Inputs/test-linux_x86_64 %p/Inputs/test-linux_x86_64.0.sancov | FileCheck %s
 
 CHECK: all-edges: 8
diff --git a/llvm/test/tools/sancov/symbolize.test b/llvm/test/tools/sancov/symbolize.test
index acf58ae1171238..4ffafb7448815f 100644
--- a/llvm/test/tools/sancov/symbolize.test
+++ b/llvm/test/tools/sancov/symbolize.test
@@ -1,4 +1,4 @@
-REQUIRES: x86-registered-target && host-byteorder-little-endian
+REQUIRES: x86-registered-target && target-byteorder-little-endian
 RUN: sancov -symbolize -strip_path_prefix="llvm/" %p/Inputs/test-linux_x86_64 %p/Inputs/test-linux_x86_64.0.sancov | FileCheck %s --check-prefixes=CHECK,STRIP
 RUN: sancov -symbolize %p/Inputs/test-linux_x86_64 %p/Inputs/test-linux_x86_64.0.sancov | FileCheck %s --check-prefixes=CHECK,NOSTRIP
 
diff --git a/llvm/test/tools/sancov/symbolize_noskip_dead_files.test b/llvm/test/tools/sancov/symbolize_noskip_dead_files.test
index 0038ea197735aa..e366bdcb2ef75f 100644
--- a/llvm/test/tools/sancov/symbolize_noskip_dead_files.test
+++ b/llvm/test/tools/sancov/symbolize_noskip_dead_files.test
@@ -1,4 +1,4 @@
-REQUIRES: x86-registered-target && host-byteorder-little-endian
+REQUIRES: x86-registered-target && target-byteorder-little-endian
 RUN: sancov -symbolize -skip-dead-files=0 -strip_path_prefix="llvm/" %p/Inputs/test-linux_x86_64 %p/Inputs/test-linux_x86_64.0.sancov | FileCheck %s
 
 CHECK: {

github-actions · 2024-09-09T21:18:11Z

✅ With the latest revision this PR passed the Python code formatter.

perry-ca · 2024-09-09T21:18:30Z

@redstar @daltenty could you review. Thanks

jh7370

I can't believe that this PR is correct for all cases (I don't know enough about some of the tools to know whether it does for those ones, but certainly the yaml2obj/llvm-objdump ones are wrong).

Also, there are certainly cases where the host machine's endianness is significant to the test, because it impacts how numbers are represented in memory. If the program were to then print those numbers as bytes, rather than as their representation (or equally, if the program were to try to interpret an arbitrary set of bytes as a number without considering whether byte swapping was necessary), then the output would be different. I therefore cannot believe that removing the host-byteorder-* directives can be correct in all cases.

Please provide more explanation why in each test case (or family of related test cases) what you've done is correct.

jh7370 · 2024-09-10T07:12:17Z

llvm/test/Object/AArch64/chained-fixups-header.test

@@ -1,4 +1,4 @@
-REQUIRES: host-byteorder-little-endian
+REQUIRES: target-byteorder-little-endian


This doesn't make sense: there is no concept of default target endianness for yaml2obj as yaml2obj is target agnostic. The endianness is determined by the yaml input file's contents.

Similarly, llvm-objdump should handle both big and little endian, with the endianness determined by the input file: there's nothing for lit to check here.

jh7370 · 2024-09-10T07:12:47Z

llvm/test/Object/AArch64/filetype-fileset.yaml

@@ -1,4 +1,4 @@
-# REQUIRES: host-byteorder-little-endian
+# REQUIRES: target-byteorder-little-endian


Same comment as above.

perry-ca · 2024-09-10T18:57:06Z

I had thought that yaml2obj would have been host independent. It probably should be so you can generate object files for a target independent of what host you are running on. If it is meant to be then we might need to look deeper into these tests. The llvm/test/Object/AArch64/filetype-fileset.yaml does pass in all four variations (target big/little, host big/little). I think I had missed one variation when double checking the rest. I put the host-byteorder back in for the yaml2obj cases.

efriedma-quic

I had thought that yaml2obj would have been host independent. It probably should be so you can generate object files for a target independent of what host you are running on. If it is meant to be then we might need to look deeper into these tests.

Yes, but it's orthogonal to this patch.

efriedma-quic · 2024-09-10T20:16:53Z

llvm/test/lit.cfg.py

@@ -364,6 +364,13 @@ def version_int(ver):
    config.available_features.add("llvm-64-bits")

 config.available_features.add("host-byteorder-" + sys.byteorder + "-endian")
+if re.match(
+    r"(aarch64_be|arc|armeb|bpfeb|lanai|m68k|mips|mips64|powerpc|powerpc64|sparc|sparcv9|s390x|s390|tce|thumbeb)-.*",
+    config.target_triple,


Maybe stick this check under the if config.target_triple:?

jh7370

Thanks. I'm "approving" this, to clear my "needs changes", but somebody who understands the original test should actually still review it.

jh7370 · 2024-09-11T07:13:34Z

llvm/test/CodeGen/Generic/allow-check.ll

@@ -1,5 +1,5 @@
 ; Avoid `!DL->isLittleEndian() && !CLI->enableBigEndian()` missmatch on PPC64BE.


Is this comment still appropriate?

Really, what we want to check here is "does the target support globalisel", since we only want to check the behavior of -global-isel=1 on such targets. But the comment is basically correct; big-endian targets don't support globalisel (with the exception of m68k), so checking endianness is a reasonable approximation.

efriedma-quic

LGTM

efriedma-quic · 2024-09-16T23:47:19Z

llvm/test/CodeGen/Generic/allow-check.ll

@@ -1,5 +1,5 @@
 ; Avoid `!DL->isLittleEndian() && !CLI->enableBigEndian()` missmatch on PPC64BE.


Really, what we want to check here is "does the target support globalisel", since we only want to check the behavior of -global-isel=1 on such targets. But the comment is basically correct; big-endian targets don't support globalisel (with the exception of m68k), so checking endianness is a reasonable approximation.

It is really the byte order of the target that matters

53e069a

perry-ca requested a review from JDevlieghere as a code owner September 9, 2024 21:14

llvmbot added debuginfo llvm:binary-utilities labels Sep 9, 2024

fix fomrating

04b2929

jh7370 requested changes Sep 10, 2024

View reviewed changes

perry-ca added 5 commits September 10, 2024 10:41

more formatting

07f5c63

trailing space

db17174

keep host-byteorder

babeaf0

added temp file

c901695

use host-byteorder here too

ec691fe

perry-ca changed the title ~~It is really the byte order of the target that matters~~ Add target-byteorder for cases where endian in target triple is what matters Sep 10, 2024

efriedma-quic reviewed Sep 10, 2024

View reviewed changes

Merge branch 'llvm:main' into perry/use-target-endian

6cfb7ee

jh7370 approved these changes Sep 11, 2024

View reviewed changes

add check

a72da6d

efriedma-quic requested a review from vitalybuka September 16, 2024 23:40

efriedma-quic approved these changes Sep 16, 2024

View reviewed changes

vitalybuka approved these changes Sep 17, 2024

View reviewed changes

abhina-sree merged commit 27b5dc4 into llvm:main Sep 23, 2024
8 checks passed

perry-ca deleted the perry/use-target-endian branch September 25, 2024 14:52

perry-ca restored the perry/use-target-endian branch September 25, 2024 14:53

		@@ -1,4 +1,4 @@
		REQUIRES: host-byteorder-little-endian
		REQUIRES: target-byteorder-little-endian

		@@ -1,4 +1,4 @@
		# REQUIRES: host-byteorder-little-endian
		# REQUIRES: target-byteorder-little-endian

		@@ -1,5 +1,5 @@
		; Avoid `!DL->isLittleEndian() && !CLI->enableBigEndian()` missmatch on PPC64BE.

Add target-byteorder for cases where endian in target triple is what matters #107915

Add target-byteorder for cases where endian in target triple is what matters #107915

Uh oh!

Conversation

perry-ca commented Sep 9, 2024

Uh oh!

llvmbot commented Sep 9, 2024

Uh oh!

llvmbot commented Sep 9, 2024

Uh oh!

github-actions bot commented Sep 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

perry-ca commented Sep 9, 2024

Uh oh!

jh7370 left a comment

Choose a reason for hiding this comment

Uh oh!

jh7370 Sep 10, 2024

Choose a reason for hiding this comment

Uh oh!

jh7370 Sep 10, 2024

Choose a reason for hiding this comment

Uh oh!

perry-ca commented Sep 10, 2024

Uh oh!

efriedma-quic left a comment

Choose a reason for hiding this comment

Uh oh!

efriedma-quic Sep 10, 2024

Choose a reason for hiding this comment

Uh oh!

jh7370 left a comment

Choose a reason for hiding this comment

Uh oh!

jh7370 Sep 11, 2024

Choose a reason for hiding this comment

Uh oh!

efriedma-quic Sep 16, 2024

Choose a reason for hiding this comment

Uh oh!

efriedma-quic left a comment

Choose a reason for hiding this comment

Uh oh!

efriedma-quic Sep 16, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Sep 9, 2024 •

edited

Loading