Skip to content

Add target-byteorder for cases where endian in target triple is what matters #107915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 23, 2024
Merged

Add target-byteorder for cases where endian in target triple is what matters #107915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
53e069a
It is really the byte order of the target that matters
perry-ca Sep 9, 2024
04b2929
fix fomrating
perry-ca Sep 9, 2024
07f5c63
more formatting
perry-ca Sep 10, 2024
db17174
trailing space
perry-ca Sep 10, 2024
babeaf0
keep host-byteorder
perry-ca Sep 10, 2024
c901695
added temp file
perry-ca Sep 10, 2024
ec691fe
use host-byteorder here too
perry-ca Sep 10, 2024
6cfb7ee
Merge branch 'llvm:main' into perry/use-target-endian
perry-ca Sep 10, 2024
a72da6d
add check
perry-ca Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/test/CodeGen/Generic/allow-check.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
; Avoid `!DL->isLittleEndian() && !CLI->enableBigEndian()` missmatch on PPC64BE.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment still appropriate?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really, what we want to check here is "does the target support globalisel", since we only want to check the behavior of -global-isel=1 on such targets. But the comment is basically correct; big-endian targets don't support globalisel (with the exception of m68k), so checking endianness is a reasonable approximation.

; REQUIRES: host-byteorder-little-endian
; REQUIRES: target-byteorder-little-endian

; -global-isel=1 is unsupported.
; XFAIL: target=loongarch{{.*}}
Expand Down
8 changes: 8 additions & 0 deletions llvm/test/lit.cfg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,14 @@ def version_int(ver):
config.available_features.add("llvm-64-bits")

config.available_features.add("host-byteorder-" + sys.byteorder + "-endian")
if config.target_triple:
if re.match(
r"(aarch64_be|arc|armeb|bpfeb|lanai|m68k|mips|mips64|powerpc|powerpc64|sparc|sparcv9|s390x|s390|tce|thumbeb)-.*",
config.target_triple,
):
config.available_features.add("target-byteorder-big-endian")
else:
config.available_features.add("target-byteorder-little-endian")

if sys.platform in ["win32"]:
# ExecutionEngine, no weak symbols in COFF.
Expand Down
Loading