Skip to content

[X86] Fix missing immediate qualifier in #108593 #110072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

phoebewang
Copy link
Contributor

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Sep 26, 2024

@llvm/pr-subscribers-backend-x86

Author: Phoebe Wang (phoebewang)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/110072.diff

1 Files Affected:

  • (modified) llvm/utils/TableGen/X86ManualInstrMapping.def (+8-8)
diff --git a/llvm/utils/TableGen/X86ManualInstrMapping.def b/llvm/utils/TableGen/X86ManualInstrMapping.def
index bc539d792f38df..7c5a6033237fe9 100644
--- a/llvm/utils/TableGen/X86ManualInstrMapping.def
+++ b/llvm/utils/TableGen/X86ManualInstrMapping.def
@@ -246,14 +246,14 @@ ENTRY(VCVTTPD2DQZ256rm, VCVTTPD2DQYrm)
 ENTRY(VCVTTPD2DQZ256rr, VCVTTPD2DQYrr)
 ENTRY(VDIVPDZ256rm, VDIVPDYrm)
 ENTRY(VDIVPDZ256rr, VDIVPDYrr)
-ENTRY(VEXTRACTF64x2Z256mr, VEXTRACTF128mri)
-ENTRY(VEXTRACTF64x2Z256rr, VEXTRACTF128rri)
-ENTRY(VEXTRACTI64x2Z256mr, VEXTRACTI128mri)
-ENTRY(VEXTRACTI64x2Z256rr, VEXTRACTI128rri)
-ENTRY(VINSERTF64x2Z256rm, VINSERTF128rmi)
-ENTRY(VINSERTF64x2Z256rr, VINSERTF128rri)
-ENTRY(VINSERTI64x2Z256rm, VINSERTI128rmi)
-ENTRY(VINSERTI64x2Z256rr, VINSERTI128rri)
+ENTRY(VEXTRACTF64x2Z256mri, VEXTRACTF128mri)
+ENTRY(VEXTRACTF64x2Z256rri, VEXTRACTF128rri)
+ENTRY(VEXTRACTI64x2Z256mri, VEXTRACTI128mri)
+ENTRY(VEXTRACTI64x2Z256rri, VEXTRACTI128rri)
+ENTRY(VINSERTF64x2Z256rmi, VINSERTF128rmi)
+ENTRY(VINSERTF64x2Z256rri, VINSERTF128rri)
+ENTRY(VINSERTI64x2Z256rmi, VINSERTI128rmi)
+ENTRY(VINSERTI64x2Z256rri, VINSERTI128rri)
 ENTRY(VMAXCPDZ256rm, VMAXCPDYrm)
 ENTRY(VMAXCPDZ256rr, VMAXCPDYrr)
 ENTRY(VMAXPDZ256rm, VMAXPDYrm)

@llvmbot
Copy link
Member

llvmbot commented Sep 26, 2024

@llvm/pr-subscribers-tablegen

Author: Phoebe Wang (phoebewang)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/110072.diff

1 Files Affected:

  • (modified) llvm/utils/TableGen/X86ManualInstrMapping.def (+8-8)
diff --git a/llvm/utils/TableGen/X86ManualInstrMapping.def b/llvm/utils/TableGen/X86ManualInstrMapping.def
index bc539d792f38df..7c5a6033237fe9 100644
--- a/llvm/utils/TableGen/X86ManualInstrMapping.def
+++ b/llvm/utils/TableGen/X86ManualInstrMapping.def
@@ -246,14 +246,14 @@ ENTRY(VCVTTPD2DQZ256rm, VCVTTPD2DQYrm)
 ENTRY(VCVTTPD2DQZ256rr, VCVTTPD2DQYrr)
 ENTRY(VDIVPDZ256rm, VDIVPDYrm)
 ENTRY(VDIVPDZ256rr, VDIVPDYrr)
-ENTRY(VEXTRACTF64x2Z256mr, VEXTRACTF128mri)
-ENTRY(VEXTRACTF64x2Z256rr, VEXTRACTF128rri)
-ENTRY(VEXTRACTI64x2Z256mr, VEXTRACTI128mri)
-ENTRY(VEXTRACTI64x2Z256rr, VEXTRACTI128rri)
-ENTRY(VINSERTF64x2Z256rm, VINSERTF128rmi)
-ENTRY(VINSERTF64x2Z256rr, VINSERTF128rri)
-ENTRY(VINSERTI64x2Z256rm, VINSERTI128rmi)
-ENTRY(VINSERTI64x2Z256rr, VINSERTI128rri)
+ENTRY(VEXTRACTF64x2Z256mri, VEXTRACTF128mri)
+ENTRY(VEXTRACTF64x2Z256rri, VEXTRACTF128rri)
+ENTRY(VEXTRACTI64x2Z256mri, VEXTRACTI128mri)
+ENTRY(VEXTRACTI64x2Z256rri, VEXTRACTI128rri)
+ENTRY(VINSERTF64x2Z256rmi, VINSERTF128rmi)
+ENTRY(VINSERTF64x2Z256rri, VINSERTF128rri)
+ENTRY(VINSERTI64x2Z256rmi, VINSERTI128rmi)
+ENTRY(VINSERTI64x2Z256rri, VINSERTI128rri)
 ENTRY(VMAXCPDZ256rm, VMAXCPDYrm)
 ENTRY(VMAXCPDZ256rr, VMAXCPDYrr)
 ENTRY(VMAXPDZ256rm, VMAXPDYrm)

Copy link
Contributor

@KanRobert KanRobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phoebewang phoebewang merged commit a96876f into llvm:main Sep 26, 2024
11 checks passed
@phoebewang phoebewang deleted the VEXTRACT branch September 26, 2024 03:28
Sterling-Augustine pushed a commit to Sterling-Augustine/llvm-project that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants