-
Notifications
You must be signed in to change notification settings - Fork 14.4k
[llvm][cmake][Trivial] use /Zc:preprocessor with MSVC only explicitly #111520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Only MSVC recognizes this flag, so be explicit. As an example the Intel C++ Compiler (IntelLLVM in CMake) also has an MSVC compatible CLI, but does not support this flag.
@zero9178 can you take a look please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me given that the flag is effectively a workaround for MSVC internals and backwards compatibility
Thanks. Can I ask you to merge please, I don't have access. |
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/66/builds/4655 Here is the relevant piece of the build log for the reference
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/146/builds/1337 Here is the relevant piece of the build log for the reference
|
Only MSVC recognizes this flag, so be explicit. As an example the Intel C++ Compiler (IntelLLVM in CMake) also has an MSVC compatible CLI, but does not suppport this flag.