Skip to content

[llvm][cmake][Trivial] use /Zc:preprocessor with MSVC only explicitly #111520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2024
Merged

[llvm][cmake][Trivial] use /Zc:preprocessor with MSVC only explicitly #111520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/cmake/modules/HandleLLVMOptions.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,7 +581,7 @@ if( MSVC )

append("/Zc:inline" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)

if (NOT CMAKE_CXX_COMPILER_ID MATCHES "Clang")
if (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
# Enable standards-conforming preprocessor.
# https://learn.microsoft.com/en-us/cpp/build/reference/zc-preprocessor
append("/Zc:preprocessor" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
Expand Down
Loading