[TableGen] [NFC] Remove unused includes in TableGen BE #113725

jerryyiransun · 2024-10-25T18:42:39Z

split PR as requested from #113318.

Removes unused imports in TableGen BE

github-actions · 2024-10-25T18:42:58Z

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

llvmbot · 2024-10-25T18:43:36Z

@llvm/pr-subscribers-backend-directx

@llvm/pr-subscribers-tablegen

Author: Jerry Sun (jerryyiransun)

Changes

split PR as requested from #113318.

Removes unused imports in TableGen BE

Full diff: https://github.com/llvm/llvm-project/pull/113725.diff

11 Files Affected:

(modified) llvm/utils/TableGen/Attributes.cpp (-1)
(modified) llvm/utils/TableGen/CTagsEmitter.cpp (-1)
(modified) llvm/utils/TableGen/DXILEmitter.cpp (-1)
(modified) llvm/utils/TableGen/GlobalISelCombinerEmitter.cpp (-2)
(modified) llvm/utils/TableGen/GlobalISelEmitter.cpp (-1)
(modified) llvm/utils/TableGen/InstrInfoEmitter.cpp (-1)
(modified) llvm/utils/TableGen/IntrinsicEmitter.cpp (-1)
(modified) llvm/utils/TableGen/OptionParserEmitter.cpp (-1)
(modified) llvm/utils/TableGen/PseudoLoweringEmitter.cpp (-1)
(modified) llvm/utils/TableGen/VTEmitter.cpp (-1)
(modified) llvm/utils/TableGen/WebAssemblyDisassemblerEmitter.cpp (-1)

diff --git a/llvm/utils/TableGen/Attributes.cpp b/llvm/utils/TableGen/Attributes.cpp
index ed00debc398cb9..652dd31a9adb27 100644
--- a/llvm/utils/TableGen/Attributes.cpp
+++ b/llvm/utils/TableGen/Attributes.cpp
@@ -9,7 +9,6 @@
 #include "llvm/TableGen/Error.h"
 #include "llvm/TableGen/Record.h"
 #include "llvm/TableGen/TableGenBackend.h"
-#include <vector>
 using namespace llvm;
 
 #define DEBUG_TYPE "attr-enum"
diff --git a/llvm/utils/TableGen/CTagsEmitter.cpp b/llvm/utils/TableGen/CTagsEmitter.cpp
index 3718486ff7ad4e..8c347456eb8940 100644
--- a/llvm/utils/TableGen/CTagsEmitter.cpp
+++ b/llvm/utils/TableGen/CTagsEmitter.cpp
@@ -17,7 +17,6 @@
 #include "llvm/TableGen/Error.h"
 #include "llvm/TableGen/Record.h"
 #include "llvm/TableGen/TableGenBackend.h"
-#include <algorithm>
 #include <vector>
 using namespace llvm;
 
diff --git a/llvm/utils/TableGen/DXILEmitter.cpp b/llvm/utils/TableGen/DXILEmitter.cpp
index 06bf7a0c0a8372..e5186abe370087 100644
--- a/llvm/utils/TableGen/DXILEmitter.cpp
+++ b/llvm/utils/TableGen/DXILEmitter.cpp
@@ -14,7 +14,6 @@
 #include "Basic/SequenceToOffsetTable.h"
 #include "Common/CodeGenTarget.h"
 #include "llvm/ADT/STLExtras.h"
-#include "llvm/ADT/SmallSet.h"
 #include "llvm/ADT/SmallVector.h"
 #include "llvm/ADT/StringExtras.h"
 #include "llvm/ADT/StringSet.h"
diff --git a/llvm/utils/TableGen/GlobalISelCombinerEmitter.cpp b/llvm/utils/TableGen/GlobalISelCombinerEmitter.cpp
index 78496fbe1b860b..7d6ee2f5343790 100644
--- a/llvm/utils/TableGen/GlobalISelCombinerEmitter.cpp
+++ b/llvm/utils/TableGen/GlobalISelCombinerEmitter.cpp
@@ -40,9 +40,7 @@
 #include "Common/SubtargetFeatureInfo.h"
 #include "llvm/ADT/APInt.h"
 #include "llvm/ADT/EquivalenceClasses.h"
-#include "llvm/ADT/Hashing.h"
 #include "llvm/ADT/MapVector.h"
-#include "llvm/ADT/SetVector.h"
 #include "llvm/ADT/Statistic.h"
 #include "llvm/ADT/StringExtras.h"
 #include "llvm/ADT/StringSet.h"
diff --git a/llvm/utils/TableGen/GlobalISelEmitter.cpp b/llvm/utils/TableGen/GlobalISelEmitter.cpp
index c53f705a38db8f..3a3dd21c411c7c 100644
--- a/llvm/utils/TableGen/GlobalISelEmitter.cpp
+++ b/llvm/utils/TableGen/GlobalISelEmitter.cpp
@@ -38,7 +38,6 @@
 #include "Common/GlobalISel/GlobalISelMatchTable.h"
 #include "Common/GlobalISel/GlobalISelMatchTableExecutorEmitter.h"
 #include "Common/InfoByHwMode.h"
-#include "Common/SubtargetFeatureInfo.h"
 #include "llvm/ADT/Statistic.h"
 #include "llvm/CodeGenTypes/LowLevelType.h"
 #include "llvm/CodeGenTypes/MachineValueType.h"
diff --git a/llvm/utils/TableGen/InstrInfoEmitter.cpp b/llvm/utils/TableGen/InstrInfoEmitter.cpp
index 5653434ddd6827..0e4e2c2ff1268c 100644
--- a/llvm/utils/TableGen/InstrInfoEmitter.cpp
+++ b/llvm/utils/TableGen/InstrInfoEmitter.cpp
@@ -24,7 +24,6 @@
 #include "llvm/ADT/STLExtras.h"
 #include "llvm/ADT/SmallVector.h"
 #include "llvm/ADT/StringExtras.h"
-#include "llvm/Support/Casting.h"
 #include "llvm/Support/raw_ostream.h"
 #include "llvm/TableGen/Error.h"
 #include "llvm/TableGen/Record.h"
diff --git a/llvm/utils/TableGen/IntrinsicEmitter.cpp b/llvm/utils/TableGen/IntrinsicEmitter.cpp
index c8b5ec146dc503..cc71fbe8e33e38 100644
--- a/llvm/utils/TableGen/IntrinsicEmitter.cpp
+++ b/llvm/utils/TableGen/IntrinsicEmitter.cpp
@@ -29,7 +29,6 @@
 #include <array>
 #include <cassert>
 #include <cctype>
-#include <limits>
 #include <map>
 #include <optional>
 #include <string>
diff --git a/llvm/utils/TableGen/OptionParserEmitter.cpp b/llvm/utils/TableGen/OptionParserEmitter.cpp
index 424cf16e719d5d..260d2ba700b59a 100644
--- a/llvm/utils/TableGen/OptionParserEmitter.cpp
+++ b/llvm/utils/TableGen/OptionParserEmitter.cpp
@@ -15,7 +15,6 @@
 #include "llvm/TableGen/TableGenBackend.h"
 #include <cstring>
 #include <map>
-#include <memory>
 
 using namespace llvm;
 
diff --git a/llvm/utils/TableGen/PseudoLoweringEmitter.cpp b/llvm/utils/TableGen/PseudoLoweringEmitter.cpp
index 9e09bdae76fd41..cdbd546df5fa7a 100644
--- a/llvm/utils/TableGen/PseudoLoweringEmitter.cpp
+++ b/llvm/utils/TableGen/PseudoLoweringEmitter.cpp
@@ -16,7 +16,6 @@
 #include "llvm/TableGen/Error.h"
 #include "llvm/TableGen/Record.h"
 #include "llvm/TableGen/TableGenBackend.h"
-#include <vector>
 using namespace llvm;
 
 #define DEBUG_TYPE "pseudo-lowering"
diff --git a/llvm/utils/TableGen/VTEmitter.cpp b/llvm/utils/TableGen/VTEmitter.cpp
index 8f4bcd5fccc73d..4cbc7abd699d20 100644
--- a/llvm/utils/TableGen/VTEmitter.cpp
+++ b/llvm/utils/TableGen/VTEmitter.cpp
@@ -10,7 +10,6 @@
 #include "llvm/Support/raw_ostream.h"
 #include "llvm/TableGen/Record.h"
 #include "llvm/TableGen/TableGenBackend.h"
-#include <array>
 #include <cassert>
 #include <map>
 using namespace llvm;
diff --git a/llvm/utils/TableGen/WebAssemblyDisassemblerEmitter.cpp b/llvm/utils/TableGen/WebAssemblyDisassemblerEmitter.cpp
index 7373494e8b12f8..873c03c8554753 100644
--- a/llvm/utils/TableGen/WebAssemblyDisassemblerEmitter.cpp
+++ b/llvm/utils/TableGen/WebAssemblyDisassemblerEmitter.cpp
@@ -15,7 +15,6 @@
 
 #include "WebAssemblyDisassemblerEmitter.h"
 #include "Common/CodeGenInstruction.h"
-#include "llvm/ADT/STLExtras.h"
 #include "llvm/Support/raw_ostream.h"
 #include "llvm/TableGen/Record.h"

llvmbot · 2024-10-25T18:43:36Z

@llvm/pr-subscribers-llvm-globalisel

Author: Jerry Sun (jerryyiransun)

Changes

split PR as requested from #113318.

Removes unused imports in TableGen BE

Full diff: https://github.com/llvm/llvm-project/pull/113725.diff

11 Files Affected:

(modified) llvm/utils/TableGen/Attributes.cpp (-1)
(modified) llvm/utils/TableGen/CTagsEmitter.cpp (-1)
(modified) llvm/utils/TableGen/DXILEmitter.cpp (-1)
(modified) llvm/utils/TableGen/GlobalISelCombinerEmitter.cpp (-2)
(modified) llvm/utils/TableGen/GlobalISelEmitter.cpp (-1)
(modified) llvm/utils/TableGen/InstrInfoEmitter.cpp (-1)
(modified) llvm/utils/TableGen/IntrinsicEmitter.cpp (-1)
(modified) llvm/utils/TableGen/OptionParserEmitter.cpp (-1)
(modified) llvm/utils/TableGen/PseudoLoweringEmitter.cpp (-1)
(modified) llvm/utils/TableGen/VTEmitter.cpp (-1)
(modified) llvm/utils/TableGen/WebAssemblyDisassemblerEmitter.cpp (-1)

diff --git a/llvm/utils/TableGen/Attributes.cpp b/llvm/utils/TableGen/Attributes.cpp
index ed00debc398cb9..652dd31a9adb27 100644
--- a/llvm/utils/TableGen/Attributes.cpp
+++ b/llvm/utils/TableGen/Attributes.cpp
@@ -9,7 +9,6 @@
 #include "llvm/TableGen/Error.h"
 #include "llvm/TableGen/Record.h"
 #include "llvm/TableGen/TableGenBackend.h"
-#include <vector>
 using namespace llvm;
 
 #define DEBUG_TYPE "attr-enum"
diff --git a/llvm/utils/TableGen/CTagsEmitter.cpp b/llvm/utils/TableGen/CTagsEmitter.cpp
index 3718486ff7ad4e..8c347456eb8940 100644
--- a/llvm/utils/TableGen/CTagsEmitter.cpp
+++ b/llvm/utils/TableGen/CTagsEmitter.cpp
@@ -17,7 +17,6 @@
 #include "llvm/TableGen/Error.h"
 #include "llvm/TableGen/Record.h"
 #include "llvm/TableGen/TableGenBackend.h"
-#include <algorithm>
 #include <vector>
 using namespace llvm;
 
diff --git a/llvm/utils/TableGen/DXILEmitter.cpp b/llvm/utils/TableGen/DXILEmitter.cpp
index 06bf7a0c0a8372..e5186abe370087 100644
--- a/llvm/utils/TableGen/DXILEmitter.cpp
+++ b/llvm/utils/TableGen/DXILEmitter.cpp
@@ -14,7 +14,6 @@
 #include "Basic/SequenceToOffsetTable.h"
 #include "Common/CodeGenTarget.h"
 #include "llvm/ADT/STLExtras.h"
-#include "llvm/ADT/SmallSet.h"
 #include "llvm/ADT/SmallVector.h"
 #include "llvm/ADT/StringExtras.h"
 #include "llvm/ADT/StringSet.h"
diff --git a/llvm/utils/TableGen/GlobalISelCombinerEmitter.cpp b/llvm/utils/TableGen/GlobalISelCombinerEmitter.cpp
index 78496fbe1b860b..7d6ee2f5343790 100644
--- a/llvm/utils/TableGen/GlobalISelCombinerEmitter.cpp
+++ b/llvm/utils/TableGen/GlobalISelCombinerEmitter.cpp
@@ -40,9 +40,7 @@
 #include "Common/SubtargetFeatureInfo.h"
 #include "llvm/ADT/APInt.h"
 #include "llvm/ADT/EquivalenceClasses.h"
-#include "llvm/ADT/Hashing.h"
 #include "llvm/ADT/MapVector.h"
-#include "llvm/ADT/SetVector.h"
 #include "llvm/ADT/Statistic.h"
 #include "llvm/ADT/StringExtras.h"
 #include "llvm/ADT/StringSet.h"
diff --git a/llvm/utils/TableGen/GlobalISelEmitter.cpp b/llvm/utils/TableGen/GlobalISelEmitter.cpp
index c53f705a38db8f..3a3dd21c411c7c 100644
--- a/llvm/utils/TableGen/GlobalISelEmitter.cpp
+++ b/llvm/utils/TableGen/GlobalISelEmitter.cpp
@@ -38,7 +38,6 @@
 #include "Common/GlobalISel/GlobalISelMatchTable.h"
 #include "Common/GlobalISel/GlobalISelMatchTableExecutorEmitter.h"
 #include "Common/InfoByHwMode.h"
-#include "Common/SubtargetFeatureInfo.h"
 #include "llvm/ADT/Statistic.h"
 #include "llvm/CodeGenTypes/LowLevelType.h"
 #include "llvm/CodeGenTypes/MachineValueType.h"
diff --git a/llvm/utils/TableGen/InstrInfoEmitter.cpp b/llvm/utils/TableGen/InstrInfoEmitter.cpp
index 5653434ddd6827..0e4e2c2ff1268c 100644
--- a/llvm/utils/TableGen/InstrInfoEmitter.cpp
+++ b/llvm/utils/TableGen/InstrInfoEmitter.cpp
@@ -24,7 +24,6 @@
 #include "llvm/ADT/STLExtras.h"
 #include "llvm/ADT/SmallVector.h"
 #include "llvm/ADT/StringExtras.h"
-#include "llvm/Support/Casting.h"
 #include "llvm/Support/raw_ostream.h"
 #include "llvm/TableGen/Error.h"
 #include "llvm/TableGen/Record.h"
diff --git a/llvm/utils/TableGen/IntrinsicEmitter.cpp b/llvm/utils/TableGen/IntrinsicEmitter.cpp
index c8b5ec146dc503..cc71fbe8e33e38 100644
--- a/llvm/utils/TableGen/IntrinsicEmitter.cpp
+++ b/llvm/utils/TableGen/IntrinsicEmitter.cpp
@@ -29,7 +29,6 @@
 #include <array>
 #include <cassert>
 #include <cctype>
-#include <limits>
 #include <map>
 #include <optional>
 #include <string>
diff --git a/llvm/utils/TableGen/OptionParserEmitter.cpp b/llvm/utils/TableGen/OptionParserEmitter.cpp
index 424cf16e719d5d..260d2ba700b59a 100644
--- a/llvm/utils/TableGen/OptionParserEmitter.cpp
+++ b/llvm/utils/TableGen/OptionParserEmitter.cpp
@@ -15,7 +15,6 @@
 #include "llvm/TableGen/TableGenBackend.h"
 #include <cstring>
 #include <map>
-#include <memory>
 
 using namespace llvm;
 
diff --git a/llvm/utils/TableGen/PseudoLoweringEmitter.cpp b/llvm/utils/TableGen/PseudoLoweringEmitter.cpp
index 9e09bdae76fd41..cdbd546df5fa7a 100644
--- a/llvm/utils/TableGen/PseudoLoweringEmitter.cpp
+++ b/llvm/utils/TableGen/PseudoLoweringEmitter.cpp
@@ -16,7 +16,6 @@
 #include "llvm/TableGen/Error.h"
 #include "llvm/TableGen/Record.h"
 #include "llvm/TableGen/TableGenBackend.h"
-#include <vector>
 using namespace llvm;
 
 #define DEBUG_TYPE "pseudo-lowering"
diff --git a/llvm/utils/TableGen/VTEmitter.cpp b/llvm/utils/TableGen/VTEmitter.cpp
index 8f4bcd5fccc73d..4cbc7abd699d20 100644
--- a/llvm/utils/TableGen/VTEmitter.cpp
+++ b/llvm/utils/TableGen/VTEmitter.cpp
@@ -10,7 +10,6 @@
 #include "llvm/Support/raw_ostream.h"
 #include "llvm/TableGen/Record.h"
 #include "llvm/TableGen/TableGenBackend.h"
-#include <array>
 #include <cassert>
 #include <map>
 using namespace llvm;
diff --git a/llvm/utils/TableGen/WebAssemblyDisassemblerEmitter.cpp b/llvm/utils/TableGen/WebAssemblyDisassemblerEmitter.cpp
index 7373494e8b12f8..873c03c8554753 100644
--- a/llvm/utils/TableGen/WebAssemblyDisassemblerEmitter.cpp
+++ b/llvm/utils/TableGen/WebAssemblyDisassemblerEmitter.cpp
@@ -15,7 +15,6 @@
 
 #include "WebAssemblyDisassemblerEmitter.h"
 #include "Common/CodeGenInstruction.h"
-#include "llvm/ADT/STLExtras.h"
 #include "llvm/Support/raw_ostream.h"
 #include "llvm/TableGen/Record.h"

llvm/utils/TableGen/WebAssemblyDisassemblerEmitter.cpp

llvm/utils/TableGen/InstrInfoEmitter.cpp

llvm/utils/TableGen/CTagsEmitter.cpp

jurahul · 2024-10-28T16:56:20Z

Minor comment: import is not a C++ term. Can you change the description to "Remove unused includes in TableGen BE" (note change in capitalization as well).

arsenm · 2024-10-28T18:36:29Z

Minor comment: import is not a C++ term.

It is actually, but we're not using modules yet

github-actions · 2024-10-29T03:26:28Z

@jerryyiransun Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

split PR as requested from llvm#113318. Removes unused imports in TableGen BE

remove unused imports in TableGen BE

5c29d2d

llvmbot added tablegen llvm:globalisel backend:DirectX labels Oct 25, 2024

jerryyiransun mentioned this pull request Oct 25, 2024

[TableGen] [NFC] Refine TableGen code to comply with clang-tidy checks #113318

Merged

redstar requested review from jurahul, kparzysz, tmatheson-arm and Paul-C-Anagnostopoulos October 25, 2024 19:30

kparzysz reviewed Oct 25, 2024

View reviewed changes

llvm/utils/TableGen/WebAssemblyDisassemblerEmitter.cpp Outdated Show resolved Hide resolved

llvm/utils/TableGen/InstrInfoEmitter.cpp Outdated Show resolved Hide resolved

add back STLExtra.h and Casting.h

7a9f2db

jerryyiransun requested a review from kparzysz October 28, 2024 14:58

jurahul reviewed Oct 28, 2024

View reviewed changes

llvm/utils/TableGen/CTagsEmitter.cpp Show resolved Hide resolved

add imports for tuple in CTagsEmitter.cpp

944f867

jerryyiransun requested a review from jurahul October 28, 2024 16:54

jerryyiransun changed the title ~~[TableGen] [NFC] Remove Unused Imports in TableGen BE~~ [TableGen] [NFC] Remove unused includes in TableGen BE Oct 28, 2024

jurahul approved these changes Oct 28, 2024

View reviewed changes

Merge branch 'main' into jerryyiransun/tablegen-remove-unused-imports

0ff4c4a

arsenm merged commit 00ca207 into llvm:main Oct 29, 2024
6 of 7 checks passed

NoumanAmir657 pushed a commit to NoumanAmir657/llvm-project that referenced this pull request Nov 4, 2024

[TableGen] [NFC] Remove unused includes in TableGen BE (llvm#113725)

e3e72cc

split PR as requested from llvm#113318. Removes unused imports in TableGen BE

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[TableGen] [NFC] Remove unused includes in TableGen BE #113725

[TableGen] [NFC] Remove unused includes in TableGen BE #113725

Uh oh!

jerryyiransun commented Oct 25, 2024

Uh oh!

github-actions bot commented Oct 25, 2024

Uh oh!

llvmbot commented Oct 25, 2024 •

edited

Loading

Uh oh!

llvmbot commented Oct 25, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jurahul commented Oct 28, 2024

Uh oh!

arsenm commented Oct 28, 2024

Uh oh!

Uh oh!

github-actions bot commented Oct 29, 2024

Uh oh!

Uh oh!

[TableGen] [NFC] Remove unused includes in TableGen BE #113725

[TableGen] [NFC] Remove unused includes in TableGen BE #113725

Uh oh!

Conversation

jerryyiransun commented Oct 25, 2024

Uh oh!

github-actions bot commented Oct 25, 2024

Uh oh!

llvmbot commented Oct 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

llvmbot commented Oct 25, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jurahul commented Oct 28, 2024

Uh oh!

arsenm commented Oct 28, 2024

Uh oh!

Uh oh!

github-actions bot commented Oct 29, 2024

Uh oh!

Uh oh!

llvmbot commented Oct 25, 2024 •

edited

Loading