Add extendhfxf2 into compiler rt #113897
Merged
Add extendhfxf2 into compiler rt #113897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biabbas
force-pushed
the
extendhfxf2
branch
2 times, most recently
from
4393971 to
270ec84
Compare
biabbas
force-pushed
the
extendhfxf2
branch
5 times, most recently
from
8ddd5b9 to
b80ef73
Compare
arichardson
approved these changes
Nov 5, 2024
arichardson
reviewed
Nov 5, 2024
arichardson
reviewed
Nov 5, 2024
biabbas
force-pushed
the
extendhfxf2
branch
3 times, most recently
from
20116c2 to
ba8237d
Compare
arichardson
reviewed
Nov 6, 2024
arichardson
reviewed
Nov 6, 2024
arichardson
approved these changes
Nov 6, 2024
biabbas
commented
Nov 7, 2024
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
arichardson
approved these changes
Nov 7, 2024
Co-authored-by: Alexander Richardson <[email protected]>
|
I've updated the branch for merge. |
|
This broke the Solaris/amd64 bot again. |
I'll update the test case asap. |
arichardson
reviewed
Nov 26, 2024
arichardson
reviewed
Nov 26, 2024
| #include <stdio.h> | ||
|
|
||
| #include "int_lib.h" | ||
|
|
| return ret; | ||
| } | ||
|
|
||
| char assumption_1[sizeof(_Float16) * CHAR_BIT == 16] = {0}; |
arichardson
reviewed
Nov 26, 2024
Merged
|
This also broke the compiler-rt tests on mingw, again: https://github.com/mstorsjo/llvm-mingw/actions/runs/12021713343/job/33522994914 and https://github.com/mstorsjo/llvm-mingw/actions/runs/12021713343/job/33522995313 I can test the incremental fix in #117665. |
arichardson
added a commit
that referenced
this pull request
Nov 26, 2024
Fix changes in #113897 Co-authored-by: Alex Richardson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105181
Retry of pr #109090 and #111099.
ping @arichardson
Regards.