Fix extendhfxf2 test

[biabbas]

Fix changes in #113897

cc @arichardson

[github-actions]

✅ With the latest revision this PR passed the C/C++ code formatter.

[arichardson]

Thanks for the quick fixes - I realize I didn't actually review the test properly.

[arichardson]

one nit otherwise LGTM. Thanks!

[biabbas]

this expects hi and lo. I'll have to change this.

[biabbas]

f80 functions in fp_test are only for x86_64

[arichardson]

Ah yes that should be relaxed to just be gated on fp80 support

[arichardson]

I.e. change the if in fp_test.h to just HAS_80_BIT_LONG_DOUBLE

[biabbas]

I made the test exclusive for x86_64. Would __uint128_t be available on i386?

[arichardson]

It may or may not - but we shouldn't need it for this. I'll take care of that as a follo-up.

[abdulraheembeigh]

LGTM. Thanks.

[mstorsjo]

This change does fix tests on x86_64 mingw, but it still fails on i686 mingw, and it also breaks a number of previously working tests there - have a look: https://github.com/mstorsjo/llvm-project/actions/runs/12026429539/job/33525399943

You can try this out for yourself - cherrypick mstorsjo@gha-mingw-compiler-rt onto your branch and push to your fork, and it will run these tests in your own github fork (no PR needed even).

[mstorsjo]

Previously, we specifically checked for x86_64 here, but HAS_80_BIT_LONG_DOUBLE also is true on i686 mingw, so this will start executing these codepaths on i686 now as well.

[biabbas]

Yeah, https://github.com/mstorsjo/llvm-project/actions/runs/12026429539/job/33525399943 this suggests uint128t is not defined, thus this should be only enabled for x86_64.
Alternatively we could check if __uint128t is available with check_c_source_compiles and add another flag like we do here

llvm-project/compiler-rt/lib/builtins/CMakeLists.txt

Line 873 in f082782

check_c_source_compiles("_Float16 foo(_Float16 x) { return x; }

.

[mstorsjo]

FWIW, I also tested with an addition like this: mstorsjo@de5ad3a

That unbreaks the other unrelated tests, but this new test still is failing: https://github.com/mstorsjo/llvm-project/actions/runs/12026756315/job/33526363616

# | D:\a\llvm-project\llvm-project\compiler-rt\test\builtins\Unit\extendhfxf2_test.c:16:13: error: call to undeclared function 'compareResultF80'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
# |    16 |   int ret = compareResultF80(x, expectedHi, expectedLo);
# |       |             ^

So a similar condition would need to be added back to the condition within the actual test here as well.

[rorth]

Things are similar on Solaris/amd64:

  Builtins-i386-sunos :: divdf3_test.c
  Builtins-i386-sunos :: divsc3_test.c
  Builtins-i386-sunos :: divsf3_test.c
  Builtins-i386-sunos :: extendhfsf2_test.c
  Builtins-i386-sunos :: extendhfxf2_test.c
  Builtins-i386-sunos :: truncdfhf2_test.c
  Builtins-i386-sunos :: truncdfsf2_test.c
  Builtins-i386-sunos :: truncsfhf2_test.c

AFAICS the failures are all for the same reason:

In file included from /vol/llvm/src/llvm-project/local/compiler-rt/test/builtins/Unit/divdf3_test.c:7:
/vol/llvm/src/llvm-project/local/compiler-rt/test/builtins/Unit/fp_test.h:235:5: error: use of undeclared identifier '__uint128_t'
  235 |     __uint128_t x = ((__uint128_t)hi << 64) + lo;
      |     ^

__uint128_t etc. isn't available on 32-bit x86 (not only on Solaris, same on Linux/x86_64 -m32).

[biabbas]

I've added the necessary checks to the test case now.

[mstorsjo]

I've added the necessary checks to the test case now.

Thanks! This version works for the mingw tests on i686 and x86_64.

[arichardson]

This LGTM, fp_test.h guards can be cleaned up later.