[mlir][python] Raise maximum allowed version #114050
Conversation
Raises the maximum allowed versions to more recent versions, which is a basic enabler to install them in a venv using Python 3.13.
marbre
requested review from
ftynse,
makslevental and
stellaraccident
as code owners
|
@llvm/pr-subscribers-mlir Author: Marius Brehler (marbre) ChangesRaises the maximum allowed versions to more recent versions, which is a basic enabler to install them in a venv using Python 3.13. Full diff: https://github.com/llvm/llvm-project/pull/114050.diff 1 Files Affected:
diff --git a/mlir/python/requirements.txt b/mlir/python/requirements.txt
index d1b5418cca5b23..eeaac27461b118 100644
--- a/mlir/python/requirements.txt
+++ b/mlir/python/requirements.txt
@@ -1,4 +1,4 @@
-numpy>=1.19.5, <=1.26
-pybind11>=2.9.0, <=2.10.3
+numpy>=1.19.5, <=2.1.2
+pybind11>=2.9.0, <=2.13.6
PyYAML>=5.4.0, <=6.0.1
-ml_dtypes>=0.1.0, <=0.4.0 # provides several NumPy dtype extensions, including the bf16
+ml_dtypes>=0.1.0, <=0.5.0 # provides several NumPy dtype extensions, including the bf16
|
| @@ -1,4 +1,4 @@ | |||
| numpy>=1.19.5, <=1.26 | |||
| pybind11>=2.9.0, <=2.10.3 | |||
| numpy>=1.19.5, <=2.1.2 | |||
There was a problem hiding this comment.
How much can we trust the CI checks for this version upgrade? Moving from numpy 1 --> 2 caused (is still causing) quite a bit of ecosystem churn (https://numpy.org/doc/stable/numpy_2_0_migration_guide.html).
Is this a "merge and see if anyone complains" scenario? Or should some other tests/experiments be run or the change be announced on Discourse?
There was a problem hiding this comment.
Honestly, IDK. I tested this locally and made sure check-mlir-python passes but nothing more...
There was a problem hiding this comment.
I don't think it's our responsibility to keep a lid on this? Anyone that has tighter constraints on numpy will have it in their own requirements.txt. The natural way such things get resolved is pip does dependency resolution but since we're not distributing a package, it falls to the user to be aware.
There was a problem hiding this comment.
Well, these version increases LGTM from a downstream (https://github.com/iree-org/iree) perspective, at least.
Raises the maximum allowed versions to more recent versions, which is a basic enabler to install them in a venv using Python 3.13.
Raises the maximum allowed versions to more recent versions, which is a basic enabler to install them in a venv using Python 3.13.
Raises the maximum allowed versions to more recent versions, which is a basic enabler to install them in a venv using Python 3.13.