Skip to content

[mlir][python] Raise maximum allowed version #114050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2024
Merged

[mlir][python] Raise maximum allowed version #114050

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions mlir/python/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
numpy>=1.19.5, <=1.26
pybind11>=2.9.0, <=2.10.3
numpy>=1.19.5, <=2.1.2
pybind11>=2.9.0, <=2.13.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How much can we trust the CI checks for this version upgrade? Moving from numpy 1 --> 2 caused (is still causing) quite a bit of ecosystem churn (https://numpy.org/doc/stable/numpy_2_0_migration_guide.html).

Is this a "merge and see if anyone complains" scenario? Or should some other tests/experiments be run or the change be announced on Discourse?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, IDK. I tested this locally and made sure check-mlir-python passes but nothing more...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's our responsibility to keep a lid on this? Anyone that has tighter constraints on numpy will have it in their own requirements.txt. The natural way such things get resolved is pip does dependency resolution but since we're not distributing a package, it falls to the user to be aware.

PyYAML>=5.4.0, <=6.0.1
ml_dtypes>=0.1.0, <=0.4.0 # provides several NumPy dtype extensions, including the bf16
ml_dtypes>=0.1.0, <=0.5.0 # provides several NumPy dtype extensions, including the bf16
Loading