Fix failing test gcov_ctr_ref_init.ll #114428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test failing after merge of PR: Enable aggressive constant merge in GlobalMerge for AIX
|
@llvm/pr-subscribers-backend-powerpc Author: Zaara Syeda (syzaara) ChangesTest failing after merge of PR: Full diff: https://github.com/llvm/llvm-project/pull/114428.diff 1 Files Affected:
diff --git a/llvm/test/CodeGen/PowerPC/gcov_ctr_ref_init.ll b/llvm/test/CodeGen/PowerPC/gcov_ctr_ref_init.ll
index 4710d5c14e5b19..1e819652fad473 100644
--- a/llvm/test/CodeGen/PowerPC/gcov_ctr_ref_init.ll
+++ b/llvm/test/CodeGen/PowerPC/gcov_ctr_ref_init.ll
@@ -20,11 +20,12 @@ target triple = "powerpc-ibm-aix"
; CHECK-NEXT: __llvm_gcov_ctr:
; CHECK-NEXT: .space 16
; CHECK-NEXT: __llvm_gcov_ctr.1:
-; CHECK-NEXT: .extern .llvm_gcda_start_file[PR]
+; CHECK: .extern .llvm_gcda_start_file[PR]
; CHECK-NEXT: .extern .llvm_gcda_emit_function[PR]
; CHECK-NEXT: .extern .llvm_gcda_emit_arcs[PR]
; CHECK-NEXT: .extern .llvm_gcda_summary_info[PR]
; CHECK-NEXT: .extern .llvm_gcda_end_file[PR]
+; CHECK-NEXT: .csect __llvm_gcov_ctr_section[RW],3
; CHECK-RW-NEXT: .ref __llvm_covinit[RW]
; CHECK-RO-NEXT: .ref __llvm_covinit[RO]
|
w2yehia
approved these changes
Oct 31, 2024
smallp-o-p
pushed a commit
to smallp-o-p/llvm-project
that referenced
this pull request
Nov 3, 2024
Fix test failing after merge of commit: ccddd13
NoumanAmir657
pushed a commit
to NoumanAmir657/llvm-project
that referenced
this pull request
Nov 4, 2024
Fix test failing after merge of commit: ccddd13
| ; The first .csect directive below is specifying the content of the csect. | ||
| ; The second .csect directive below is used to insert the .ref pseudo | ||
| ; instruction. | ||
| ; CHECK: .csect __llvm_gcov_ctr_section[RW],3 |
There was a problem hiding this comment.
@syzaara:
The content of the csect is significant (and should be checked, not just skipped).
The change that added this test was responsible for creating the section so that references to the counters would, in turn, cause the initialization symbols to be kept.
There was a problem hiding this comment.
Posted #117577 to address this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix test failing after merge of commit: ccddd13