Skip to content

Fix failing test gcov_ctr_ref_init.ll #114428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Fix failing test gcov_ctr_ref_init.ll #114428

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e32631
Fix failing test gcov_ctr_ref_init.ll
syzaara Oct 31, 2024
3a8e721
Fix test
syzaara Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions llvm/test/CodeGen/PowerPC/gcov_ctr_ref_init.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,11 @@ target triple = "powerpc-ibm-aix"
; CHECK-NEXT: L..__llvm_covinit_functions:
; CHECK-NEXT: .vbyte 4, __llvm_gcov_writeout[DS]
; CHECK-NEXT: .vbyte 4, __llvm_gcov_reset[DS]
; The first .csect directive below is specifying the content of the csect.
; The second .csect directive below is used to insert the .ref pseudo
; instruction.
; CHECK: .csect __llvm_gcov_ctr_section[RW],3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@syzaara:
The content of the csect is significant (and should be checked, not just skipped).
The change that added this test was responsible for creating the section so that references to the counters would, in turn, cause the initialization symbols to be kept.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posted #117577 to address this

; CHECK: .csect __llvm_gcov_ctr_section[RW],3
; CHECK-NEXT: .lglobl __llvm_gcov_ctr # @_MergedGlobals
; CHECK-NEXT: .lglobl __llvm_gcov_ctr.1
; CHECK-NEXT: .align 3
; CHECK-NEXT: L.._MergedGlobals:
; CHECK-NEXT: __llvm_gcov_ctr:
; CHECK-NEXT: .space 16
; CHECK-NEXT: __llvm_gcov_ctr.1:
; CHECK-NEXT: .extern .llvm_gcda_start_file[PR]
; CHECK-NEXT: .extern .llvm_gcda_emit_function[PR]
; CHECK-NEXT: .extern .llvm_gcda_emit_arcs[PR]
; CHECK-NEXT: .extern .llvm_gcda_summary_info[PR]
; CHECK-NEXT: .extern .llvm_gcda_end_file[PR]
; CHECK-RW-NEXT: .ref __llvm_covinit[RW]
; CHECK-RO-NEXT: .ref __llvm_covinit[RO]

Expand Down
Loading