-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[GlobalISel] Add G_STEP_VECTOR instruction #115598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
00bca23
[GlobalISel] Add G_STEP_VECTOR instruction
tschuett 1593236
small fixes
tschuett 5e6deac
white space
tschuett 4ec7442
fix validation
tschuett 68d0a39
address review comments
tschuett 04f916f
docs + >= -> >
tschuett 5cfd041
fix type
tschuett f38c31d
docs
tschuett 7a26409
more docs
tschuett 3f47c37
fix riscv legalizer validation
tschuett f95d39b
address review comments
tschuett c3a674e
unmerge
tschuett File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
# RUN: not --crash llc -verify-machineinstrs -mtriple=arm64 -run-pass none -o /dev/null %s 2>&1 | FileCheck %s | ||
# REQUIRES: aarch64-registered-target | ||
|
||
--- | ||
name: g_step_vector | ||
body: | | ||
bb.0: | ||
|
||
%0:_(s32) = G_CONSTANT i32 4 | ||
|
||
; CHECK: operand must be cimm | ||
%1:_(s32) = G_STEP_VECTOR %0 | ||
|
||
; CHECK: step must be > 0 | ||
%2:_(s32) = G_STEP_VECTOR i32 -1 | ||
|
||
; CHECK: Destination type must be a scalable vector | ||
%3:_(<4 x s64>) = G_STEP_VECTOR i32 5 | ||
|
||
; CHECK: Destination element type must be scalar | ||
%4:_(<vscale x 4 x p0>) = G_STEP_VECTOR i32 9 | ||
|
||
; CHECK: step bitwidth differs from result type element bitwidth | ||
%6:_(<vscale x 2 x s33>) = G_STEP_VECTOR i32 56 | ||
|
||
%7:_(<vscale x 2 x s128>) = G_STEP_VECTOR i128 79 | ||
|
||
... | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also add a variant to return a uint64_t for convenience?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I replaced the APInt by an uint64_t. The step is unsigned.