-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[flang] Add cmake error if building with clang-cl and MSVC 17.12 #120114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A bug in the C++ library in MSVC 17.12 prevents clang-cl from being able to build flang with that library version. This bug is not present in 17.11 or earlier, nor in 17.13. This patch adds a cmake error telling the user to either upgrade or downgrade to avoid the bug.
@h-vetinari I couldn't ping you for review on this for some reason but thought you might have some input on it |
Thanks. While I'm not excited about this, it does sound like a reasonable thing to avoid predictably falling over later. Hopefully 17.13 is out soon, because we can't really do compiler roll-backs in the images provided for GHA and azure pipelines (to my knowledge at least). |
For posterity: The underlying MSVC problem is microsoft/STL#4959. |
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/builds/17905 Here is the relevant piece of the build log for the reference
|
A bug in the C++ library in MSVC 17.12 prevents clang-cl from being able to build flang with that library version. This bug is not present in 17.11 or earlier, nor in 17.13. This patch adds a cmake error telling the user to either upgrade or downgrade to avoid the bug.