[flang] Add David Truby as maintainer for Flang on Windows #142619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidTruby
requested review from
sscalpone,
tblah,
kiranchandramohan,
jeanPerier and
mrkajetanp
|
You have my ok, but should probably approved by code owners that so far had those responsibilities. |
tblah
approved these changes
Jun 4, 2025
luporl
approved these changes
Jun 4, 2025
Thanks for the ping. I don't have a commit bit here (so my approval counts for little), but I'm very interested in keeping flang in good shape on windows, so I welcome any efforts to that effect. Thanks for stepping up @DavidTruby! |
jeanPerier
approved these changes
Jun 10, 2025
There was a problem hiding this comment.
I am happy with @DavidTruby taking this responsibility, thanks David!
|
Thanks everyone! |
tomtor
pushed a commit
to tomtor/llvm-project
that referenced
this pull request
Jun 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all, I'd like to propose myself as a Maintainer for Flang on Windows.
I feel that this would be helpful to have an obvious point of contact for people submitting Windows issues for Flang, as well as reviews. While we don't generally see a huge number of Windows issues currently, I've worked with Windows on Flang in the past, for example in the following PRs: #120114, #116667, #90758, #72519; as well as helped other people fix Windows issues in their PRs: #130253, #108017, #74728.
I've added as reviewers a few people I have worked on Windows issues with in the past, and would like to ping a couple more who I can't add, if they'd like to give input (@h-vetinari @bradking).