[libclc] Have all targets build all CLC functions #124779
Conversation
|
CC @rjodinchr |
Do we not have at least one sample of these? We should probably go out of the way to add one so the build infrastructure doesn't decay |
I was working on porting over FMA yesterday and clspv/spirv have custom implementations for that. So that'll hopefully be coming up soon. That depends on a bunch of the integer functions in #116786 so there's a bit of a pipeline to flush first. But yeah we can wait for that to all go in. I'm not so worried about the infrastructure decaying since the OpenCL layer isn't changing, but it would save on unnecessary churn. The only other thing they custom define is vstore_half but I've not looked into what's going on there, and that'll be a wee way off yet. |
This removes all remaining SPIR-V workarounds for CLC functions, in an effort to streamline the CLC implementation and prevent further issues that llvm#124614 had to fix. This commit fixes the same issue for the SPIR-V targets. Target-specific CLC implementations can and will exist, but for now they're all identical and so the target-specific SOURCES files have been removed. Target implementations now always include the 'generic' CLC directory, meaning we can avoid unnecessary duplication of SOURCES listings.
frasercrmck
force-pushed
the
libclc-clc-buildall
branch
from
da311e7 to
06dec25
Compare
This removes all remaining SPIR-V workarounds for CLC functions, in an effort to streamline the CLC implementation and prevent further issues that llvm#124614 had to fix. This commit fixes the same issue for the SPIR-V targets. Target-specific CLC implementations can and will exist, but for now they're all identical and so the target-specific SOURCES files have been removed. Target implementations now always include the 'generic' CLC directory, meaning we can avoid unnecessary duplication of SOURCES listings.
This removes all remaining SPIR-V workarounds for CLC functions, in an effort to streamline the CLC implementation and prevent further issues that #124614 had to fix. This commit fixes the same issue for the SPIR-V targets.
Target-specific CLC implementations can and will exist, but for now they're all identical and so the target-specific SOURCES files have been removed. Target implementations now always include the 'generic' CLC directory, meaning we can avoid unnecessary duplication of SOURCES listings.