libclc: clspv: add missing clc_isnan.cl dependency #124614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clc_isnan.cl is needed since llvm#124097
|
@frasercrmck, could you review please? |
dneto0
approved these changes
Jan 27, 2025
|
Sorry about that! Should |
frasercrmck
approved these changes
Jan 28, 2025
|
@frasercrmck , I cannot merge it myself, could you do it please?
I'm not sure, I would guess yes, but without testing it, it's hard to be 100% sure. |
|
Thank you |
frasercrmck
added a commit
to frasercrmck/llvm-project
that referenced
this pull request
Jan 28, 2025
This removes all remaining SPIR-V workarounds for CLC functions, in an effort to streamline the CLC implementation and prevent further issues that llvm#124614 had to fix. This commit fixes the same issue for the SPIR-V targets. Target-specific CLC implementations can and will exist, but for now they're all identical and so the target-specific SOURCES files have been removed. Target implementations now always include the 'generic' CLC directory, meaning we can avoid unnecessary duplication of SOURCES listings.
frasercrmck
added a commit
to frasercrmck/llvm-project
that referenced
this pull request
Feb 6, 2025
This removes all remaining SPIR-V workarounds for CLC functions, in an effort to streamline the CLC implementation and prevent further issues that llvm#124614 had to fix. This commit fixes the same issue for the SPIR-V targets. Target-specific CLC implementations can and will exist, but for now they're all identical and so the target-specific SOURCES files have been removed. Target implementations now always include the 'generic' CLC directory, meaning we can avoid unnecessary duplication of SOURCES listings.
frasercrmck
added a commit
that referenced
this pull request
Feb 10, 2025
This removes all remaining SPIR-V workarounds for CLC functions, in an effort to streamline the CLC implementation and prevent further issues that #124614 had to fix. This commit fixes the same issue for the SPIR-V targets. Target-specific CLC implementations can and will exist, but for now they're all identical and so the target-specific SOURCES files have been removed. Target implementations now always include the 'generic' CLC directory, meaning we can avoid unnecessary duplication of SOURCES listings.
Icohedron
pushed a commit
to Icohedron/llvm-project
that referenced
this pull request
Feb 11, 2025
This removes all remaining SPIR-V workarounds for CLC functions, in an effort to streamline the CLC implementation and prevent further issues that llvm#124614 had to fix. This commit fixes the same issue for the SPIR-V targets. Target-specific CLC implementations can and will exist, but for now they're all identical and so the target-specific SOURCES files have been removed. Target implementations now always include the 'generic' CLC directory, meaning we can avoid unnecessary duplication of SOURCES listings.
karolherbst
added a commit
to karolherbst/llvm-project
that referenced
this pull request
May 21, 2025
The fma software emulation requires it. Similar to llvm#124614
karolherbst
added a commit
to karolherbst/llvm-project
that referenced
this pull request
May 22, 2025
The fma software emulation requires it. Similar to llvm#124614
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
May 27, 2025
The fma software emulation requires it. Similar to llvm/llvm-project#124614
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
May 27, 2025
The fma software emulation requires it. Similar to llvm/llvm-project#124614
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clc_isnan.cl is needed since #124097