[asan][test] Attempt to fix suppressions-alloc-dealloc-mismatch.cpp on Darwin

[benlangmuir]

Add %env_asan_opts=alloc_dealloc_mismatch=1 since it is disabled by default.

rdar://143830493

[llvmbot]

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Ben Langmuir (benlangmuir)

Changes

Add %env_asan_opts=alloc_dealloc_mismatch=1 since it is disabled by default.

rdar://143830493

---

Full diff: https://github.com/llvm/llvm-project/pull/124987.diff

1 Files Affected:

• (modified) compiler-rt/test/asan/TestCases/suppressions-alloc-dealloc-mismatch.cpp (+3-3)

diff --git a/compiler-rt/test/asan/TestCases/suppressions-alloc-dealloc-mismatch.cpp b/compiler-rt/test/asan/TestCases/suppressions-alloc-dealloc-mismatch.cpp
index fe88a5d0c9bf15a..df6df6aa9547111 100644
--- a/compiler-rt/test/asan/TestCases/suppressions-alloc-dealloc-mismatch.cpp
+++ b/compiler-rt/test/asan/TestCases/suppressions-alloc-dealloc-mismatch.cpp
@@ -1,10 +1,10 @@
 // Check that without suppressions, we catch the issue.
 // RUN: %clangxx_asan -O0 %s -o %t
-// RUN: not %run %t 2>&1 | FileCheck --check-prefix=CHECK-CRASH %s
+// RUN: %env_asan_opts=alloc_dealloc_mismatch=1 not %run %t 2>&1 | FileCheck --check-prefix=CHECK-CRASH %s
 
 // RUN: echo "alloc_dealloc_mismatch:function" > %t.supp
-// RUN: %clangxx_asan -O0 %s -o %t && %env_asan_opts=suppressions='"%t.supp"' %run %t 2>&1 | FileCheck --check-prefix=CHECK-IGNORE %s
-// RUN: %clangxx_asan -O3 %s -o %t && %env_asan_opts=suppressions='"%t.supp"' %run %t 2>&1 | FileCheck --check-prefix=CHECK-IGNORE %s
+// RUN: %clangxx_asan -O0 %s -o %t && %env_asan_opts=alloc_dealloc_mismatch=1:suppressions='"%t.supp"' %run %t 2>&1 | FileCheck --check-prefix=CHECK-IGNORE %s
+// RUN: %clangxx_asan -O3 %s -o %t && %env_asan_opts=alloc_dealloc_mismatch=1:suppressions='"%t.supp"' %run %t 2>&1 | FileCheck --check-prefix=CHECK-IGNORE %s
 
 #include <stdio.h>
 #include <stdlib.h>

[vitalybuka]

Thanks,
It was also broken on android, let see if it helps https://lab.llvm.org/buildbot/#/builders/186/builds/6091

[vitalybuka]

And windows https://lab.llvm.org/buildbot/#/builders/107/builds/7544

[vitalybuka]

Exactly as defined:

ASAN_FLAG(bool, alloc_dealloc_mismatch,
          !SANITIZER_APPLE && !SANITIZER_WINDOWS && !SANITIZER_ANDROID,
          "Report errors on malloc/delete, new/free, new/delete[], etc.")

[benlangmuir]

It looks like this fixed Windows, but not Darwin
https://green.lab.llvm.org/job/llvm.org/job/clang-stage1-cmake-RA-expensive/3251/

The new failure looks like the suppression mechanism is failing in the -O3 case

error: CHECK-IGNORE: expected string not found in input
// CHECK-IGNORE: strlen ignored
                 ^
<stdin>:1:1: note: scanning from here
=================================================================
^
<stdin>:2:28: note: possible intended match here
==78843==ERROR: AddressSanitizer: alloc-dealloc-mismatch (malloc vs operator delete) on 0x602000000070
                           ^

[benlangmuir]

Ah, I see in compiler-rt/test/asan/TestCases/suppressions-function.cpp:

// FIXME: atos does not work for inlined functions, yet llvm-symbolizer
// does not always work with debug info on Darwin.
// UNSUPPORTED: darwin

So it seems this is a known issue with suppressions in optimized builds. I'll apply the same thing here unless you have a better idea.

Edit: done in 4985804

[dyung]

Can we get this change cherry-picked to the release branch? We are seeing the Windows ASAN failures on our internal bot that is building the release branch.

[benlangmuir]

/cherry-pick f0d05b0 751ae26 4985804

[llvmbot]

/cherry-pick f0d05b0 751ae26 4985804

Error: Command failed due to missing milestone.

[benlangmuir]

/cherry-pick f0d05b0 751ae26 4985804

[llvmbot]

/pull-request #125583