[asan][test][MSVC] Disabling test on MSVC x86 because of optimized builds #125871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
compiler-rt
compiler-rt:asan
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: Zack Johnson (zacklj89) ChangesIncluding #124987, we have failures on Windows on x86 with Full diff: https://github.com/llvm/llvm-project/pull/125871.diff 1 Files Affected:
diff --git a/compiler-rt/test/asan/TestCases/suppressions-alloc-dealloc-mismatch.cpp b/compiler-rt/test/asan/TestCases/suppressions-alloc-dealloc-mismatch.cpp
index 6ab796b1c76a69..67cb7e9827b0e3 100644
--- a/compiler-rt/test/asan/TestCases/suppressions-alloc-dealloc-mismatch.cpp
+++ b/compiler-rt/test/asan/TestCases/suppressions-alloc-dealloc-mismatch.cpp
@@ -12,6 +12,7 @@
// FIXME: atos does not work for inlined functions, yet llvm-symbolizer
// does not always work with debug info on Darwin.
// UNSUPPORTED: darwin
+// UNSUPPORTED: target={{.*windows-msvc.*}} && asan-32-bits
#include <stdio.h>
#include <stdlib.h>
|
benlangmuir
reviewed
Feb 5, 2025
|
@benlangmuir we have that test disabled in our fork for MSVC x86 as well. I think the builds/tests here on GitHub only utilize x64 which is why it passes here? I'll make a push calling those out explicitly. |
zacklj89
deleted the
users/zacklj89/asan-disable-suppressions-test-x86
branch
|
Thanks for the heads up! We're just trying to shift bite-sized contributions to upstream rather than internal as we ingest |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/55/builds/6634 Here is the relevant piece of the build log for the reference |
Icohedron
pushed a commit
to Icohedron/llvm-project
that referenced
this pull request
Feb 11, 2025
…ilds (llvm#125871) Including llvm#124987, we have failures on Windows on x86 with `/O2` builds, similar to Darwin. This disables the test for MSVC-x86.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including #124987, we have failures on Windows on x86 with
/O2builds, similar to Darwin. This disables the test for MSVC-x86.