Skip to content

LLVM/Test: Mark Mips readcyclecounter.ll XFAIL: expensive_checks #127587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

wzssyqa
Copy link
Contributor

@wzssyqa wzssyqa commented Feb 18, 2025

expsensive_check complains that:

bb.0.entry:
%0:gpr32 = RDHWR $hwr2, 0
%1:gpr32 = ADDiu $zero, 0
$v0 = COPY %0:gpr32
$v1 = COPY %1:gpr32
RetRA implicit $v0, implicit $v1

*** Bad machine code: Using an undefined physical register ***

  • function: test_readcyclecounter
  • basic block: %bb.0 entry (0xad97ee0)
  • instruction: %0:gpr32 = RDHWR $hwr2, 0
  • operand 1: $hwr2
    LLVM ERROR: Found 1 machine code errors.

expsensive_check complains that:

bb.0.entry:
  %0:gpr32 = RDHWR $hwr2, 0
  %1:gpr32 = ADDiu $zero, 0
  $v0 = COPY %0:gpr32
  $v1 = COPY %1:gpr32
  RetRA implicit $v0, implicit $v1

*** Bad machine code: Using an undefined physical register ***
- function:    test_readcyclecounter
- basic block: %bb.0 entry (0xad97ee0)
- instruction: %0:gpr32 = RDHWR $hwr2, 0
- operand 1:   $hwr2
LLVM ERROR: Found 1 machine code errors.
@wzssyqa wzssyqa merged commit b805410 into llvm:main Feb 18, 2025
9 checks passed
@brad0
Copy link
Contributor

brad0 commented Feb 18, 2025

cc @MaskRay @topperc

wldfngrs pushed a commit to wldfngrs/llvm-project that referenced this pull request Feb 19, 2025
…m#127587)

expsensive_check complains that:

bb.0.entry:
  %0:gpr32 = RDHWR $hwr2, 0
  %1:gpr32 = ADDiu $zero, 0
  $v0 = COPY %0:gpr32
  $v1 = COPY %1:gpr32
  RetRA implicit $v0, implicit $v1

*** Bad machine code: Using an undefined physical register ***
- function:    test_readcyclecounter
- basic block: %bb.0 entry (0xad97ee0)
- instruction: %0:gpr32 = RDHWR $hwr2, 0
- operand 1:   $hwr2
LLVM ERROR: Found 1 machine code errors.
@MaskRay
Copy link
Member

MaskRay commented Feb 19, 2025

This a new test from #127553 for the readcyclecounter new feature. In this case it's not a good idea to add XFAIL: expensive_checks, which seems suggest a serious problem. Better to revert the feature.

@yingopq
Copy link
Contributor

yingopq commented Feb 19, 2025

I have fixed this error, and would commit it later. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants