[NFC][Coro] Use CloneFunctionInto for coroutine cloning instead of CloneFunction<Part>

[artempyanykh]

Stacked PRs:

• [NFC][Cloning] Move DebugInfoFinder decl closer to its place of usage #129154
• [NFC][Cloning] Clean up comments in CloneFunctionInto #129153
• [NFC][Cloning] Remove now unused CollectDebugInfoForCloning #129152
• [NFC][Cloning] Remove now unused FindDebugInfoToIdentityMap #129151
• [NFC][Coro] Remove now unused CommonDebugInfo in CoroSplit #129150
• ->[NFC][Coro] Use CloneFunctionInto for coroutine cloning instead of CloneFunction<Part> #129149

---

[NFC][Coro] Use CloneFunctionInto for coroutine cloning instead of CloneFunction

Summary:
CloneFunctionInto now is fast on its own and we don't need to use
CloneFunctionAttributes/Metadata/Body separately.

CommonDebugInfo in CoroClone is now unused and is cleaned up separately
in the next diff in the stack.

Test Plan:
ninja check-all

[llvmbot]

@llvm/pr-subscribers-coroutines

Author: Artem Pianykh (artempyanykh)

Changes

Stacked PRs:

• #129154
• #129153
• #129152
• #129151
• #129150
• ->#129149
• #129148
• #129147
• #129146
• #129145
• #129144
• #129143

---

[NFC][Coro] Use CloneFunctionInto for coroutine cloning instead of CloneFunction<Part>

Summary:
CloneFunctionInto now is fast on its own and we don't need to use
CloneFunctionAttributes/Metadata/Body separately.

CommonDebugInfo in CoroClone is now unused and is cleaned up separately
in the next diff in the stack.

Test Plan:
ninja check-all

---

Full diff: https://github.com/llvm/llvm-project/pull/129149.diff

1 Files Affected:

• (modified) llvm/lib/Transforms/Coroutines/CoroSplit.cpp (+2-8)

diff --git a/llvm/lib/Transforms/Coroutines/CoroSplit.cpp b/llvm/lib/Transforms/Coroutines/CoroSplit.cpp
index 8179d5c0b29b5..7bc0a400ac1fb 100644
--- a/llvm/lib/Transforms/Coroutines/CoroSplit.cpp
+++ b/llvm/lib/Transforms/Coroutines/CoroSplit.cpp
@@ -922,14 +922,8 @@ void coro::BaseCloner::create() {
   auto savedLinkage = NewF->getLinkage();
   NewF->setLinkage(llvm::GlobalValue::ExternalLinkage);
 
-  MetadataPredicate IdentityMD = [&](const Metadata *MD) {
-    return CommonDebugInfo.contains(MD);
-  };
-  CloneFunctionAttributesInto(NewF, &OrigF, VMap, false);
-  CloneFunctionMetadataInto(*NewF, OrigF, VMap, RF_None, nullptr, nullptr,
-                            &IdentityMD);
-  CloneFunctionBodyInto(*NewF, OrigF, VMap, RF_None, Returns, "", nullptr,
-                        nullptr, nullptr, &IdentityMD);
+  CloneFunctionInto(NewF, &OrigF, VMap,
+                    CloneFunctionChangeType::LocalChangesOnly, Returns);
 
   auto &Context = NewF->getContext();
 

[llvmbot]

@llvm/pr-subscribers-llvm-transforms

Author: Artem Pianykh (artempyanykh)

Changes

Stacked PRs:

• #129154
• #129153
• #129152
• #129151
• #129150
• ->#129149
• #129148
• #129147
• #129146
• #129145
• #129144
• #129143

---

[NFC][Coro] Use CloneFunctionInto for coroutine cloning instead of CloneFunction<Part>

Summary:
CloneFunctionInto now is fast on its own and we don't need to use
CloneFunctionAttributes/Metadata/Body separately.

CommonDebugInfo in CoroClone is now unused and is cleaned up separately
in the next diff in the stack.

Test Plan:
ninja check-all

---

Full diff: https://github.com/llvm/llvm-project/pull/129149.diff

1 Files Affected:

• (modified) llvm/lib/Transforms/Coroutines/CoroSplit.cpp (+2-8)

diff --git a/llvm/lib/Transforms/Coroutines/CoroSplit.cpp b/llvm/lib/Transforms/Coroutines/CoroSplit.cpp
index 8179d5c0b29b5..7bc0a400ac1fb 100644
--- a/llvm/lib/Transforms/Coroutines/CoroSplit.cpp
+++ b/llvm/lib/Transforms/Coroutines/CoroSplit.cpp
@@ -922,14 +922,8 @@ void coro::BaseCloner::create() {
   auto savedLinkage = NewF->getLinkage();
   NewF->setLinkage(llvm::GlobalValue::ExternalLinkage);
 
-  MetadataPredicate IdentityMD = [&](const Metadata *MD) {
-    return CommonDebugInfo.contains(MD);
-  };
-  CloneFunctionAttributesInto(NewF, &OrigF, VMap, false);
-  CloneFunctionMetadataInto(*NewF, OrigF, VMap, RF_None, nullptr, nullptr,
-                            &IdentityMD);
-  CloneFunctionBodyInto(*NewF, OrigF, VMap, RF_None, Returns, "", nullptr,
-                        nullptr, nullptr, &IdentityMD);
+  CloneFunctionInto(NewF, &OrigF, VMap,
+                    CloneFunctionChangeType::LocalChangesOnly, Returns);
 
   auto &Context = NewF->getContext();