-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[NFC][Cloning] Clean up comments in CloneFunctionInto #129153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NFC][Cloning] Clean up comments in CloneFunctionInto #129153
Conversation
Summary: Some comments no longer make sense nor refer to an existing code path. Test Plan: ninja check-llvm-unit stack-info: PR: #129153, branch: users/artempyanykh/fast-coro-upstream-part2-take2/11
7a07326
to
400a806
Compare
e841dd1
to
4177775
Compare
@llvm/pr-subscribers-coroutines @llvm/pr-subscribers-llvm-transforms Author: Artem Pianykh (artempyanykh) ChangesStacked PRs:
[NFC][Cloning] Clean up comments in CloneFunctionIntoSummary: Test Plan: Full diff: https://github.com/llvm/llvm-project/pull/129153.diff 1 Files Affected:
diff --git a/llvm/lib/Transforms/Utils/CloneFunction.cpp b/llvm/lib/Transforms/Utils/CloneFunction.cpp
index f32d9454eb076..979cbad0d82c0 100644
--- a/llvm/lib/Transforms/Utils/CloneFunction.cpp
+++ b/llvm/lib/Transforms/Utils/CloneFunction.cpp
@@ -266,24 +266,13 @@ void llvm::CloneFunctionInto(Function *NewFunc, const Function *OldFunc,
if (OldFunc->isDeclaration())
return;
- // When we remap instructions within the same module, we want to avoid
- // duplicating inlined DISubprograms, so record all subprograms we find as we
- // duplicate instructions and then freeze them in the MD map. We also record
- // information about dbg.value and dbg.declare to avoid duplicating the
- // types.
DebugInfoFinder DIFinder;
- // Track the subprogram attachment that needs to be cloned to fine-tune the
- // mapping within the same module.
if (Changes < CloneFunctionChangeType::DifferentModule) {
- // Need to find subprograms, types, and compile units.
-
assert((NewFunc->getParent() == nullptr ||
NewFunc->getParent() == OldFunc->getParent()) &&
"Expected NewFunc to have the same parent, or no parent");
} else {
- // Need to find all the compile units.
-
assert((NewFunc->getParent() == nullptr ||
NewFunc->getParent() != OldFunc->getParent()) &&
"Expected NewFunc to have different parents, or no parent");
|
Summary: Some comments no longer make sense nor refer to an existing code path. Test Plan: ninja check-llvm-unit stack-info: PR: llvm/llvm-project#129153, branch: users/artempyanykh/fast-coro-upstream-part2-take2/11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
400a806
to
62454d3
Compare
62454d3
to
e2e5b39
Compare
c670400
to
395b2e4
Compare
Summary: Some comments no longer make sense nor refer to an existing code path. Test Plan: ninja check-llvm-unit stack-info: PR: #129153, branch: users/artempyanykh/fast-coro-upstream-part2-take2/11
e2e5b39
to
f711cec
Compare
395b2e4
to
86a30c8
Compare
Summary: Some comments no longer make sense nor refer to an existing code path. Test Plan: ninja check-llvm-unit stack-info: PR: #129153, branch: users/artempyanykh/fast-coro-upstream-part2-take2/11
f711cec
to
fd9ac7b
Compare
Summary: Some comments no longer make sense nor refer to an existing code path. Test Plan: ninja check-llvm-unit stack-info: PR: #129153, branch: users/artempyanykh/fast-coro-upstream-part2-take2/11
bee5d34
to
a9b5f38
Compare
fbb3160
to
0bb1f98
Compare
Summary: Some comments no longer make sense nor refer to an existing code path. Test Plan: ninja check-llvm-unit stack-info: PR: #129153, branch: users/artempyanykh/fast-coro-upstream-part2-take2/11
a9b5f38
to
9253bd3
Compare
9253bd3
to
95de6d8
Compare
Summary: Some comments no longer make sense nor refer to an existing code path. Test Plan: ninja check-llvm-unit stack-info: PR: llvm/llvm-project#129153, branch: users/artempyanykh/fast-coro-upstream-part2-take2/11
4a68cde
to
2688088
Compare
Summary: Some comments no longer make sense nor refer to an existing code path. Test Plan: ninja check-llvm-unit stack-info: PR: #129153, branch: users/artempyanykh/fast-coro-upstream-part2-take2/11
95de6d8
to
faa3b3a
Compare
faa3b3a
to
4e49c7f
Compare
e2aef42
to
6b37028
Compare
Summary: Some comments no longer make sense nor refer to an existing code path. Test Plan: ninja check-llvm-unit stack-info: PR: #129153, branch: users/artempyanykh/fast-coro-upstream-part2-take2/11
4e49c7f
to
cd22b53
Compare
6b37028
to
712ba5d
Compare
Summary: Some comments no longer make sense nor refer to an existing code path. Test Plan: ninja check-llvm-unit stack-info: PR: #129153, branch: users/artempyanykh/fast-coro-upstream-part2-take2/11
cd22b53
to
3779d77
Compare
712ba5d
to
9d5f7d8
Compare
Summary: Some comments no longer make sense nor refer to an existing code path. Test Plan: ninja check-llvm-unit stack-info: PR: #129153, branch: users/artempyanykh/fast-coro-upstream-part2-take2/11
3779d77
to
1335a81
Compare
1335a81
to
9c588b3
Compare
Stacked PRs:
[NFC][Cloning] Clean up comments in CloneFunctionInto
Summary:
Some comments no longer make sense nor refer to an existing code path.
Test Plan:
ninja check-llvm-unit