Skip to content

[MachinePipeliner] Use Register. NFC #130165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2025
Merged

[MachinePipeliner] Use Register. NFC #130165

merged 1 commit into from
Mar 7, 2025

Conversation

topperc
Copy link
Collaborator

@topperc topperc commented Mar 6, 2025

No description provided.

@topperc topperc requested a review from arsenm March 6, 2025 19:38
@topperc topperc merged commit f5eeeec into llvm:main Mar 7, 2025
13 checks passed
@topperc topperc deleted the pr/machinepipe branch March 7, 2025 02:39
@vitalybuka
Copy link
Collaborator

Looks like this UAF is from this patch https://lab.llvm.org/buildbot/#/builders/169/builds/9150

@vitalybuka vitalybuka mentioned this pull request Mar 7, 2025
Merged
@topperc
Copy link
Collaborator Author

topperc commented Mar 7, 2025

Looks like this UAF is from this patch https://lab.llvm.org/buildbot/#/builders/169/builds/9150

Thanks I'll take a look.

vitalybuka added a commit that referenced this pull request Mar 7, 2025
@vitalybuka
[MachinePipeliner] Fix use-after-free coping values of the same Dense…
4bc3592 
…Map (#130311)

After #130165.

In the code: `VRMap[CurStageNum][Def] = VRMap[CurStageNum][LoopVal]`
`VRMap[CurStageNum][LoopVal]` calculates a reference before
`VRMap[CurStageNum][Def]` which may rehash the DenseMap.
Then the reference can be dead.
jph-13 pushed a commit to jph-13/llvm-project that referenced this pull request Mar 21, 2025
@topperc @jph-13
[MachinePipeliner] Use Register. NFC (llvm#130165)
a13226d
jph-13 pushed a commit to jph-13/llvm-project that referenced this pull request Mar 21, 2025
@vitalybuka @jph-13
[MachinePipeliner] Fix use-after-free coping values of the same Dense…
5b6a366 
…Map (llvm#130311)

After llvm#130165.

In the code: `VRMap[CurStageNum][Def] = VRMap[CurStageNum][LoopVal]`
`VRMap[CurStageNum][LoopVal]` calculates a reference before
`VRMap[CurStageNum][Def]` which may rehash the DenseMap.
Then the reference can be dead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arsenm arsenm arsenm approved these changes

@hstk30-hw hstk30-hw hstk30-hw approved these changes

Assignees
No one assigned
Labels
llvm:codegen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@topperc @vitalybuka @arsenm @hstk30-hw