llvm-reduce: Skip setting br conditions on already constant branches #133841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we are trying to simplify branch conditions to true, ignore branches already set to a constant true. If we are simplifying to constant false, ignore the already constant false cases. This saves steps in this edge case, and avoids the side effect of running simplifycfg on blocks we did not intend to modify.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
aeubanks
approved these changes
Apr 1, 2025
arsenm
deleted the
users/arsenm/llvm-reduce/ignore-constant-condition-branches-in-reduce-conditionals
branch
Ankur-0429
pushed a commit
to Ankur-0429/llvm-project
that referenced
this pull request
Apr 2, 2025
…lvm#133841) If we are trying to simplify branch conditions to true, ignore branches already set to a constant true. If we are simplifying to constant false, ignore the already constant false cases. This saves steps in this edge case, and avoids the side effect of running simplifycfg on blocks we did not intend to modify.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are trying to simplify branch conditions to true, ignore branches
already set to a constant true. If we are simplifying to constant false,
ignore the already constant false cases. This saves steps in this edge
case, and avoids the side effect of running simplifycfg on blocks we
did not intend to modify.