llvm-reduce: Fix introducing unreachable code in simplify conditionals #133842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
aeubanks
approved these changes
Apr 1, 2025
Base automatically changed from
users/arsenm/llvm-reduce/ignore-constant-condition-branches-in-reduce-conditionals
to
main
April 2, 2025 04:41
After replacing the branch condition, this was calling simplifyCFG to perform the cleanups of the branch. This is far too heavy of a hammer. We do not want all of the extra optimizations in simplifyCFG, and this could also leave behind dead code. Instead, minimally fold the terminator and try to delete the newly dead code. This is pretty much a direct copy of what bugpoint does.
arsenm
force-pushed
the
users/arsenm/llvm-reduce/avoid-introducing-unreachable-code-simplify-conditionals
branch
from
80eec06 to
2fabdfa
Compare
arsenm
deleted the
users/arsenm/llvm-reduce/avoid-introducing-unreachable-code-simplify-conditionals
branch
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/81/builds/6082 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After replacing the branch condition, this was calling simplifyCFG to
perform the cleanups of the branch. This is far too heavy of a hammer.
We do not want all of the extra optimizations in simplifyCFG, and
this could also leave behind dead code. Instead, minimally fold the
terminator and try to delete the newly dead code.
This is pretty much a direct copy of what bugpoint does.