Skip to content

llvm-reduce: Increase operands-to-args test coverage #133853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

arsenm
Copy link
Contributor

@arsenm arsenm commented Apr 1, 2025

This wasn't checking the output for all functions.
--match-full-lines is also particularly hazardous for the
interestingness checks for avoiding asserts and broken IR.

Also add tests for some of the filtered function user types.
This wasn't covered, and is overly conservative.

This wasn't checking the output for all functions.
--match-full-lines is also particularly hazardous for the
interestingness checks for avoiding asserts and broken IR.

Also add tests for some of the filtered function user types.
This wasn't covered, and is overly conservative.
Copy link
Contributor Author

arsenm commented Apr 1, 2025

Copy link
Contributor

@fhahn fhahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor Author

arsenm commented Apr 2, 2025

Merge activity

  • Apr 2, 6:01 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Apr 2, 6:02 AM EDT: A user merged this pull request with Graphite.

@arsenm arsenm merged commit 54385f5 into main Apr 2, 2025
15 checks passed
@arsenm arsenm deleted the users/arsenm/llvm-reduce/increase-operands-to-args-test-coverage branch April 2, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants