llvm-reduce: Fix overly conservative operands-to-args user restriction #133854
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
| @@ -96,7 +96,7 @@ declare void @ptr_user(ptr) | |||
|
|
|||
| ; INTERESTING-LABEL: define void @calls_and_passes_func( | |||
| ; REDUCED-LABEL: define void @calls_and_passes_func(ptr %has_callee_and_arg_user) { | |||
| ; REDUCED: call void @has_callee_and_arg_user(ptr %has_callee_and_arg_user) | |||
| ; REDUCED: call void @has_callee_and_arg_user(ptr %has_callee_and_arg_user, ptr null) | |||
There was a problem hiding this comment.
why do we pass null here now, should we not ideally introduce a new argument?
There was a problem hiding this comment.
Whenever this this does anything, the call sites are adjusted to pass the default type value to the new argument
| return false; | ||
| }); | ||
| static bool canReplaceFunction(const Function &F) { | ||
| // TODO: Add controls to avoid ABI breaks (e.g. don't break main) |
There was a problem hiding this comment.
IMO llvm-reduce should be reducing main
There was a problem hiding this comment.
It shoul, but it would be useful to have a mode to opt out and avoid breaking anything needed to execute the function (bugpoint has a more primitive version of the option than the one I would like)
ReduceArguments already does that (though eventually I think we need an option to preserve executability) |
I assume this was a leftover from typed pointers. It's easier to replace the non-callee uses, they are just replacable pointer values.
arsenm
force-pushed
the
users/arsenm/llvm-reduce/remove-operands-to-args-function-user-restriction
branch
from
83ba71f to
e3463ee
Compare
arsenm
deleted the
users/arsenm/llvm-reduce/remove-operands-to-args-function-user-restriction
branch
llvm#133854) I assume this was a leftover from typed pointers. It's easier to replace the non-callee uses, they are just replacable pointer values.
llvm#133854) I assume this was a leftover from typed pointers. It's easier to replace the non-callee uses, they are just replacable pointer values.
I assume this was a leftover from typed pointers. It's easier to replace
the non-callee uses, they are just replacable pointer values.