[clang-tidy] Fix cert-err33-c to ignore functions with same prefixes as target
#135160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Björn Svensson <[email protected]>
…as target PR llvm#82952 introduced regexes matching for CheckedFunctions used by this checker. Fix false positives by adding end-of-string to target regexes. Signed-off-by: Björn Svensson <[email protected]>
|
@llvm/pr-subscribers-clang-tools-extra @llvm/pr-subscribers-clang-tidy Author: Björn Svensson (bjosv) ChangesPR #82952 introduced regex matching for Add a testcase and fix false positives by adding end-of-string to target regex's. Patch is 24.69 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/135160.diff 2 Files Affected:
diff --git a/clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp b/clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp
index 26befe0de59ae..cc092a9627c5f 100644
--- a/clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp
+++ b/clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp
@@ -50,183 +50,183 @@ namespace {
// with NULL argument and in this case the check is not applicable:
// `mblen, mbrlen, mbrtowc, mbtowc, wctomb, wctomb_s`.
// FIXME: The check can be improved to handle such cases.
-const llvm::StringRef CertErr33CCheckedFunctions = "^::aligned_alloc;"
- "^::asctime_s;"
- "^::at_quick_exit;"
- "^::atexit;"
- "^::bsearch;"
- "^::bsearch_s;"
- "^::btowc;"
- "^::c16rtomb;"
- "^::c32rtomb;"
- "^::calloc;"
- "^::clock;"
- "^::cnd_broadcast;"
- "^::cnd_init;"
- "^::cnd_signal;"
- "^::cnd_timedwait;"
- "^::cnd_wait;"
- "^::ctime_s;"
- "^::fclose;"
- "^::fflush;"
- "^::fgetc;"
- "^::fgetpos;"
- "^::fgets;"
- "^::fgetwc;"
- "^::fopen;"
- "^::fopen_s;"
- "^::fprintf;"
- "^::fprintf_s;"
- "^::fputc;"
- "^::fputs;"
- "^::fputwc;"
- "^::fputws;"
- "^::fread;"
- "^::freopen;"
- "^::freopen_s;"
- "^::fscanf;"
- "^::fscanf_s;"
- "^::fseek;"
- "^::fsetpos;"
- "^::ftell;"
- "^::fwprintf;"
- "^::fwprintf_s;"
- "^::fwrite;"
- "^::fwscanf;"
- "^::fwscanf_s;"
- "^::getc;"
- "^::getchar;"
- "^::getenv;"
- "^::getenv_s;"
- "^::gets_s;"
- "^::getwc;"
- "^::getwchar;"
- "^::gmtime;"
- "^::gmtime_s;"
- "^::localtime;"
- "^::localtime_s;"
- "^::malloc;"
- "^::mbrtoc16;"
- "^::mbrtoc32;"
- "^::mbsrtowcs;"
- "^::mbsrtowcs_s;"
- "^::mbstowcs;"
- "^::mbstowcs_s;"
- "^::memchr;"
- "^::mktime;"
- "^::mtx_init;"
- "^::mtx_lock;"
- "^::mtx_timedlock;"
- "^::mtx_trylock;"
- "^::mtx_unlock;"
- "^::printf_s;"
- "^::putc;"
- "^::putwc;"
- "^::raise;"
- "^::realloc;"
- "^::remove;"
- "^::rename;"
- "^::scanf;"
- "^::scanf_s;"
- "^::setlocale;"
- "^::setvbuf;"
- "^::signal;"
- "^::snprintf;"
- "^::snprintf_s;"
- "^::sprintf;"
- "^::sprintf_s;"
- "^::sscanf;"
- "^::sscanf_s;"
- "^::strchr;"
- "^::strerror_s;"
- "^::strftime;"
- "^::strpbrk;"
- "^::strrchr;"
- "^::strstr;"
- "^::strtod;"
- "^::strtof;"
- "^::strtoimax;"
- "^::strtok;"
- "^::strtok_s;"
- "^::strtol;"
- "^::strtold;"
- "^::strtoll;"
- "^::strtoul;"
- "^::strtoull;"
- "^::strtoumax;"
- "^::strxfrm;"
- "^::swprintf;"
- "^::swprintf_s;"
- "^::swscanf;"
- "^::swscanf_s;"
- "^::thrd_create;"
- "^::thrd_detach;"
- "^::thrd_join;"
- "^::thrd_sleep;"
- "^::time;"
- "^::timespec_get;"
- "^::tmpfile;"
- "^::tmpfile_s;"
- "^::tmpnam;"
- "^::tmpnam_s;"
- "^::tss_create;"
- "^::tss_get;"
- "^::tss_set;"
- "^::ungetc;"
- "^::ungetwc;"
- "^::vfprintf;"
- "^::vfprintf_s;"
- "^::vfscanf;"
- "^::vfscanf_s;"
- "^::vfwprintf;"
- "^::vfwprintf_s;"
- "^::vfwscanf;"
- "^::vfwscanf_s;"
- "^::vprintf_s;"
- "^::vscanf;"
- "^::vscanf_s;"
- "^::vsnprintf;"
- "^::vsnprintf_s;"
- "^::vsprintf;"
- "^::vsprintf_s;"
- "^::vsscanf;"
- "^::vsscanf_s;"
- "^::vswprintf;"
- "^::vswprintf_s;"
- "^::vswscanf;"
- "^::vswscanf_s;"
- "^::vwprintf_s;"
- "^::vwscanf;"
- "^::vwscanf_s;"
- "^::wcrtomb;"
- "^::wcschr;"
- "^::wcsftime;"
- "^::wcspbrk;"
- "^::wcsrchr;"
- "^::wcsrtombs;"
- "^::wcsrtombs_s;"
- "^::wcsstr;"
- "^::wcstod;"
- "^::wcstof;"
- "^::wcstoimax;"
- "^::wcstok;"
- "^::wcstok_s;"
- "^::wcstol;"
- "^::wcstold;"
- "^::wcstoll;"
- "^::wcstombs;"
- "^::wcstombs_s;"
- "^::wcstoul;"
- "^::wcstoull;"
- "^::wcstoumax;"
- "^::wcsxfrm;"
- "^::wctob;"
- "^::wctrans;"
- "^::wctype;"
- "^::wmemchr;"
- "^::wprintf_s;"
- "^::wscanf;"
- "^::wscanf_s;";
+const llvm::StringRef CertErr33CCheckedFunctions = "^::aligned_alloc$;"
+ "^::asctime_s$;"
+ "^::at_quick_exit$;"
+ "^::atexit$;"
+ "^::bsearch$;"
+ "^::bsearch_s$;"
+ "^::btowc$;"
+ "^::c16rtomb$;"
+ "^::c32rtomb$;"
+ "^::calloc$;"
+ "^::clock$;"
+ "^::cnd_broadcast$;"
+ "^::cnd_init$;"
+ "^::cnd_signal$;"
+ "^::cnd_timedwait$;"
+ "^::cnd_wait$;"
+ "^::ctime_s$;"
+ "^::fclose$;"
+ "^::fflush$;"
+ "^::fgetc$;"
+ "^::fgetpos$;"
+ "^::fgets$;"
+ "^::fgetwc$;"
+ "^::fopen$;"
+ "^::fopen_s$;"
+ "^::fprintf$;"
+ "^::fprintf_s$;"
+ "^::fputc$;"
+ "^::fputs$;"
+ "^::fputwc$;"
+ "^::fputws$;"
+ "^::fread$;"
+ "^::freopen$;"
+ "^::freopen_s$;"
+ "^::fscanf$;"
+ "^::fscanf_s$;"
+ "^::fseek$;"
+ "^::fsetpos$;"
+ "^::ftell$;"
+ "^::fwprintf$;"
+ "^::fwprintf_s$;"
+ "^::fwrite$;"
+ "^::fwscanf$;"
+ "^::fwscanf_s$;"
+ "^::getc$;"
+ "^::getchar$;"
+ "^::getenv$;"
+ "^::getenv_s$;"
+ "^::gets_s$;"
+ "^::getwc$;"
+ "^::getwchar$;"
+ "^::gmtime$;"
+ "^::gmtime_s$;"
+ "^::localtime$;"
+ "^::localtime_s$;"
+ "^::malloc$;"
+ "^::mbrtoc16$;"
+ "^::mbrtoc32$;"
+ "^::mbsrtowcs$;"
+ "^::mbsrtowcs_s$;"
+ "^::mbstowcs$;"
+ "^::mbstowcs_s$;"
+ "^::memchr$;"
+ "^::mktime$;"
+ "^::mtx_init$;"
+ "^::mtx_lock$;"
+ "^::mtx_timedlock$;"
+ "^::mtx_trylock$;"
+ "^::mtx_unlock$;"
+ "^::printf_s$;"
+ "^::putc$;"
+ "^::putwc$;"
+ "^::raise$;"
+ "^::realloc$;"
+ "^::remove$;"
+ "^::rename$;"
+ "^::scanf$;"
+ "^::scanf_s$;"
+ "^::setlocale$;"
+ "^::setvbuf$;"
+ "^::signal$;"
+ "^::snprintf$;"
+ "^::snprintf_s$;"
+ "^::sprintf$;"
+ "^::sprintf_s$;"
+ "^::sscanf$;"
+ "^::sscanf_s$;"
+ "^::strchr$;"
+ "^::strerror_s$;"
+ "^::strftime$;"
+ "^::strpbrk$;"
+ "^::strrchr$;"
+ "^::strstr$;"
+ "^::strtod$;"
+ "^::strtof$;"
+ "^::strtoimax$;"
+ "^::strtok$;"
+ "^::strtok_s$;"
+ "^::strtol$;"
+ "^::strtold$;"
+ "^::strtoll$;"
+ "^::strtoul$;"
+ "^::strtoull$;"
+ "^::strtoumax$;"
+ "^::strxfrm$;"
+ "^::swprintf$;"
+ "^::swprintf_s$;"
+ "^::swscanf$;"
+ "^::swscanf_s$;"
+ "^::thrd_create$;"
+ "^::thrd_detach$;"
+ "^::thrd_join$;"
+ "^::thrd_sleep$;"
+ "^::time$;"
+ "^::timespec_get$;"
+ "^::tmpfile$;"
+ "^::tmpfile_s$;"
+ "^::tmpnam$;"
+ "^::tmpnam_s$;"
+ "^::tss_create$;"
+ "^::tss_get$;"...
[truncated]
|
| "^::wprintf_s;" | ||
| "^::wscanf;" | ||
| "^::wscanf_s;"; | ||
| const llvm::StringRef CertErr33CCheckedFunctions = "^::aligned_alloc$;" |
There was a problem hiding this comment.
Off topic but this variable should probably be moved to the actual check implementation, instead of being in the CERTTidyModule
There was a problem hiding this comment.
Yes, this seems to be an alias to bugprone::UnusedReturnValueCheck.
I guess cert-err33-c should be moved to its own implementation similar to hicpp-ignored-remove-result.
There was a problem hiding this comment.
Ah, if it's an alias, that explains why. Nevermind then!
vbvictor
reviewed
Apr 10, 2025
Signed-off-by: Björn Svensson <[email protected]>
Missed that, thanks. Done. |
var-const
pushed a commit
to ldionne/llvm-project
that referenced
this pull request
Apr 17, 2025
…s as target (llvm#135160) PR llvm#82952 introduced regex matching for `CheckedFunctions` in `UnusedReturnValueCheck` which is used by the checker `cert-err33-c`. Add a testcase and fix false positives by adding end-of-string to target regex's. --------- Signed-off-by: Björn Svensson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #82952 introduced regex matching for
CheckedFunctionsinUnusedReturnValueCheckwhich is used by the checkercert-err33-c.Add a testcase and fix false positives by adding end-of-string to target regex's.