Skip to content

[RISCV][NFC] Add Zicsr to profiles explicitly #136134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025

Conversation

wangpc-pp
Copy link
Contributor

To avoid some misunstandings though Zicsr is implied by F/D.

To avoid some misunstandings though Zicsr is implied by F/D.
@llvmbot
Copy link
Member

llvmbot commented Apr 17, 2025

@llvm/pr-subscribers-backend-risc-v

Author: Pengcheng Wang (wangpc-pp)

Changes

To avoid some misunstandings though Zicsr is implied by F/D.


Full diff: https://github.com/llvm/llvm-project/pull/136134.diff

1 Files Affected:

  • (modified) llvm/lib/Target/RISCV/RISCVProfiles.td (+1)
diff --git a/llvm/lib/Target/RISCV/RISCVProfiles.td b/llvm/lib/Target/RISCV/RISCVProfiles.td
index bcb776e682aea..92389fecd0b1d 100644
--- a/llvm/lib/Target/RISCV/RISCVProfiles.td
+++ b/llvm/lib/Target/RISCV/RISCVProfiles.td
@@ -24,6 +24,7 @@ defvar RVA20U64BaseFeatures = [Feature64Bit,
                                FeatureStdExtF,
                                FeatureStdExtD,
                                FeatureStdExtC,
+                               FeatureStdExtZicsr,
                                FeatureStdExtZicntr,
                                FeatureStdExtZiccif,
                                FeatureStdExtZiccrse,

Copy link
Collaborator

@topperc topperc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangpc-pp wangpc-pp merged commit 5b2c743 into llvm:main Apr 18, 2025
13 checks passed
@wangpc-pp wangpc-pp deleted the main-riscv-profiles-zicsr branch April 18, 2025 02:59
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
To avoid some misunstandings though Zicsr is implied by F/D.
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
To avoid some misunstandings though Zicsr is implied by F/D.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants