[MLIR] Use mlir_target_link_libraries with MLIRTestIRDLToCppDialect #143435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace LINK_LIBS with mlir_target_link_libraries. Fixes llvm#143246. Suggested-by: Nikita Popov <[email protected]>
|
@llvm/pr-subscribers-mlir Author: Tulio Magno Quites Machado Filho (tuliom) ChangesReplace LINK_LIBS with mlir_target_link_libraries. Suggested-by: Nikita Popov <[email protected]> Full diff: https://github.com/llvm/llvm-project/pull/143435.diff 1 Files Affected:
diff --git a/mlir/test/lib/Dialect/TestIRDLToCpp/CMakeLists.txt b/mlir/test/lib/Dialect/TestIRDLToCpp/CMakeLists.txt
index 98a4bd3058a2a..103bc94d86920 100644
--- a/mlir/test/lib/Dialect/TestIRDLToCpp/CMakeLists.txt
+++ b/mlir/test/lib/Dialect/TestIRDLToCpp/CMakeLists.txt
@@ -7,8 +7,9 @@ add_mlir_library(MLIRTestIRDLToCppDialect
DEPENDS
TestIRDLToCppGen
+)
- LINK_LIBS PUBLIC
+mlir_target_link_libraries(MLIRTestIRDLToCppDialect PUBLIC
MLIRIR
MLIRPass
MLIRTransforms
|
Moxinilian
approved these changes
Jun 10, 2025
rorth
pushed a commit
to rorth/llvm-project
that referenced
this pull request
Jun 11, 2025
…lvm#143435) Replace LINK_LIBS with mlir_target_link_libraries. Fixes llvm#143246. Suggested-by: Nikita Popov <[email protected]>
tomtor
pushed a commit
to tomtor/llvm-project
that referenced
this pull request
Jun 14, 2025
…lvm#143435) Replace LINK_LIBS with mlir_target_link_libraries. Fixes llvm#143246. Suggested-by: Nikita Popov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace LINK_LIBS with mlir_target_link_libraries.
Fixes #143246.
Suggested-by: Nikita Popov [email protected]