Skip to content

[bazel] Update llvm-config.h and disable DebugLoc tracking #144125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

rnk
Copy link
Collaborator

@rnk rnk commented Jun 13, 2025

In c588224, @chapuni set
LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING to 1, but from what I can tell,
this is not the default setting for CMake builds. I think the intention
was mostly just to update llvm-config.h to fix the Bazel build.

I'm adding LLVM_ENABLE_DEBUGLOC_ORIGIN_TRACKING as well to fix the build
for the same purpose.

In c588224, @chapuni set
LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING to 1, but from what I can tell,
this is not the default setting for CMake builds. I think the intention
was mostly just to update llvm-config.h to fix the Bazel build.

I'm adding LLVM_ENABLE_DEBUGLOC_ORIGIN_TRACKING as well to fix the build
for the same purpose.
@llvmbot llvmbot added the bazel "Peripheral" support tier build system: utils/bazel label Jun 13, 2025
@rnk rnk requested review from slackito and chapuni June 13, 2025 17:26
@rnk rnk merged commit ec330cf into llvm:main Jun 13, 2025
9 checks passed
@chapuni
Copy link
Contributor

chapuni commented Jun 14, 2025

Thanks for your working.

LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING is "DISABLED" by default, and in this case, #cmakedefine01 LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING reflects the result as 1.

I am using 3.23.1. Looks like "DISABLED" isn't still "false-like string".
https://cmake.org/cmake/help/v4.0/command/if.html#basic-expressions

Let me fix it to fix HandleLLVMOptions.cmake side.

@chapuni
Copy link
Contributor

chapuni commented Jun 14, 2025

Fixed #107278 in 1bc0b08.

tomtor pushed a commit to tomtor/llvm-project that referenced this pull request Jun 14, 2025
In c588224, @chapuni set
LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING to 1, but from what I can tell,
this is not the default setting for CMake builds. I think the intention
was mostly just to update llvm-config.h to fix the Bazel build.

I'm adding LLVM_ENABLE_DEBUGLOC_ORIGIN_TRACKING as well to fix the build
for the same purpose.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel "Peripheral" support tier build system: utils/bazel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants