Fix attributes of llvm.amdgcn.make.buffer.rsrc #68609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per discussion on llvm#68453 , the make_buffer_rsrc intrinsic was incorrectly marked noclobber. This commit fixes the issue.
|
@llvm/pr-subscribers-llvm-ir @llvm/pr-subscribers-backend-amdgpu ChangesPer discussion on #68453 , the make_buffer_rsrc intrinsic was incorrectly marked noclobber. This commit fixes the issue. Full diff: https://github.com/llvm/llvm-project/pull/68609.diff 1 Files Affected:
diff --git a/llvm/include/llvm/IR/IntrinsicsAMDGPU.td b/llvm/include/llvm/IR/IntrinsicsAMDGPU.td
index 4f42462f655e260..0df66e1ffc519f2 100644
--- a/llvm/include/llvm/IR/IntrinsicsAMDGPU.td
+++ b/llvm/include/llvm/IR/IntrinsicsAMDGPU.td
@@ -999,7 +999,7 @@ def int_amdgcn_make_buffer_rsrc : DefaultAttrsIntrinsic <
llvm_i32_ty, // NumRecords / extent
llvm_i32_ty], // flags
// Attributes lifted from ptrmask + some extra argument attributes.
- [IntrNoMem, NoCapture<ArgIndex<0>>, ReadNone<ArgIndex<0>>,
+ [IntrNoMem, ReadNone<ArgIndex<0>>,
IntrSpeculatable, IntrWillReturn]>;
defset list<AMDGPURsrcIntrinsic> AMDGPUBufferIntrinsics = {
@@ -1928,7 +1928,7 @@ def int_amdgcn_inverse_ballot :
[IntrNoMem, IntrWillReturn, IntrNoCallback, IntrNoFree]>;
class AMDGPUWaveReduce<LLVMType data_ty = llvm_anyint_ty> : Intrinsic<
- [data_ty],
+ [data_ty],
[
LLVMMatchType<0>, // llvm value to reduce (SGPR/VGPR)
llvm_i32_ty // Reduction Strategy Switch for lowering ( 0: Default,
|
nikic
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion on #68453 , the make_buffer_rsrc intrinsic was incorrectly marked noclobber. This commit fixes the issue.