[TargetParser][AMDGPU] Fix getArchEntry(). #69222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayfoad
approved these changes
Oct 16, 2023
I don't see an easy way to cover that. It seems in LLVM we only call it from clang, but then the numeric id is something translated from a string id and therefore is always a known target. This was caught using amdgpu-dis, which relies on |
It's supposed to return null when an unknown target id is passed.
kosarev
force-pushed
the
fix_getarchentry
branch
from
5e45766 to
e0d8750
Compare
Guzhu-AMD
pushed a commit
to GPUOpen-Drivers/llvm-project
that referenced
this pull request
Oct 20, 2023
Local branch amd-gfx 402b76f Merged main:4434253f0fa6 into amd-gfx:7f370063677b Remote branch main 096eba1 [TargetParser][AMDGPU] Fix getArchEntry(). (llvm#69222)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's supposed to return null when an unknown target id is passed.