Skip to content

[libc++][Android] Enable Android testing in BuildKite CI #69275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 23, 2023
Merged

[libc++][Android] Enable Android testing in BuildKite CI #69275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7e2cea
[libc++][Android] Enable Android testing in BuildKite CI
rprichard Oct 17, 2023
f6f8709
Add Android as a supported OS in libcxx/docs/index.rst
rprichard Oct 20, 2023
0597d7a
Set the new Android steps as "soft_fail"
rprichard Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions libcxx/docs/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ Target platform Target architecture Notes
macOS 10.9+ i386, x86_64, arm64 Building the shared library itself requires targetting macOS 10.13+
FreeBSD 12+ i386, x86_64, arm
Linux i386, x86_64, arm, arm64 Only glibc-2.24 and later and no other libc is officially supported
Android 5.0+ i386, x86_64, arm, arm64
Windows i386, x86_64 Both MSVC and MinGW style environments, ABI in MSVC environments is :doc:`unstable <DesignDocs/ABIVersioning>`
AIX 7.2TL5+ powerpc, powerpc64
=============== ========================= ============================
Expand Down
32 changes: 32 additions & 0 deletions libcxx/utils/ci/buildkite-pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1116,3 +1116,35 @@ steps:
- exit_status: -1 # Agent was lost
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add the support mention in the documentation in this patch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We accidentally already did that in another change.

We can go ahead and revert that documentation change and move it here, if you would like? I suggested @rprichard didn't do that yesterday because I believed this follow up would land shortly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that documentation change was already reverted in #69660.

limit: 2
timeout_in_minutes: 120

- group: ":android: Android"
steps:
- label: "Android 5.0, x86 NDK"
command: "libcxx/utils/ci/run-buildbot android-ndk-21-def-x86"
artifact_paths:
- "**/test-results.xml"
- "**/*.abilist"
agents:
queue: "libcxx-builders"
os: "android"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
soft_fail: true
timeout_in_minutes: 120

- label: "Android 13, x86_64 NDK"
command: "libcxx/utils/ci/run-buildbot android-ndk-33-goog-x86_64"
artifact_paths:
- "**/test-results.xml"
- "**/*.abilist"
agents:
queue: "libcxx-builders"
os: "android"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
soft_fail: true
timeout_in_minutes: 120