Skip to content

[RISCV][NFC] Combine redundant 'if' statements #70423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2023
Merged

[RISCV][NFC] Combine redundant 'if' statements #70423

merged 1 commit into from
Oct 31, 2023

Conversation

knightXun
Copy link
Contributor

Due to the repetitive occurrence of two consecutive simple "if" statements in the code, they can be merged together. Additionally, there is a single simple "switch-case" statement, but since there are only a few cases, it can be replaced with an "if" statement.

@knightXun
Copy link
Contributor Author

cc @topperc

@benshi001 benshi001 requested a review from Hsiangkai October 30, 2023 05:50
@benshi001
Copy link
Member

benshi001 commented Oct 30, 2023 •
edited
Loading

  1. Add who contribute to RISCV recently as your reviewers.
  2. Change your commit message to [RISCV][NFC] Combine redundant 'if' statements

@knightXun knightXun changed the title [RISCV][NFC] consolidate simple conditional statements [RISCV][NFC] Combine redundant 'if' statements Oct 30, 2023
topperc
topperc reviewed Oct 30, 2023
View reviewed changes
@knightXun knightXun force-pushed the risc-disasember-nfc branch from c12a91b to 432c32d Compare October 30, 2023 06:06
@knightXun
[RISCV][NFC] Combine redundant 'if' statements
c2b4444 
Due to the repetitive occurrence of two consecutive simple "if" statements in the code, they can be merged together.
Additionally, there is a single simple "switch-case" statement, but since there are only a few cases,
it can be replaced with an "if" statement.
@knightXun knightXun force-pushed the risc-disasember-nfc branch from 432c32d to c2b4444 Compare October 30, 2023 06:42
topperc
topperc approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@topperc topperc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benshi001 benshi001 merged commit e6971e5 into llvm:main Oct 31, 2023
@knightXun knightXun deleted the risc-disasember-nfc branch October 31, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topperc topperc topperc approved these changes

@Hsiangkai Hsiangkai Awaiting requested review from Hsiangkai

@preames preames Awaiting requested review from preames

@melonedo melonedo Awaiting requested review from melonedo

Assignees
No one assigned
Labels
backend:RISC-V
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@knightXun @benshi001 @topperc @llvmbot