[clang] Avoid memcopy for small structure with padding under -ftrivial-auto-var-init #71677

serge-sans-paille · 2023-11-08T14:12:30Z

No description provided.

llvmbot · 2023-11-08T14:13:02Z

@llvm/pr-subscribers-clang

@llvm/pr-subscribers-clang-codegen

Author: None (serge-sans-paille)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/71677.diff

2 Files Affected:

(modified) clang/lib/CodeGen/CGDecl.cpp (+10-9)
(modified) clang/test/CodeGenCXX/auto-var-init.cpp (+19-20)

diff --git a/clang/lib/CodeGen/CGDecl.cpp b/clang/lib/CodeGen/CGDecl.cpp
index e5795d811c76de7..9761ae4726dc14e 100644
--- a/clang/lib/CodeGen/CGDecl.cpp
+++ b/clang/lib/CodeGen/CGDecl.cpp
@@ -1244,17 +1244,18 @@ static void emitStoresForConstant(CodeGenModule &CGM, const VarDecl &D,
   // If the initializer is small, use a handful of stores.
   if (shouldSplitConstantStore(CGM, ConstantSize)) {
     if (auto *STy = dyn_cast<llvm::StructType>(Ty)) {
-      // FIXME: handle the case when STy != Loc.getElementType().
-      if (STy == Loc.getElementType()) {
-        for (unsigned i = 0; i != constant->getNumOperands(); i++) {
-          Address EltPtr = Builder.CreateStructGEP(Loc, i);
-          emitStoresForConstant(
-              CGM, D, EltPtr, isVolatile, Builder,
-              cast<llvm::Constant>(Builder.CreateExtractValue(constant, i)),
-              IsAutoInit);
+      const llvm::StructLayout *Layout = CGM.getDataLayout().getStructLayout(
+          cast<llvm::StructType>(constant->getType()));
+      for (unsigned i = 0; i != constant->getNumOperands(); i++) {
+        CharUnits CurOff = CharUnits::fromQuantity(Layout->getElementOffset(i));
+        Address EltPtr = Builder.CreateConstInBoundsByteGEP(
+            Loc.withElementType(CGM.Int8Ty), CurOff);
+        emitStoresForConstant(
+            CGM, D, EltPtr, isVolatile, Builder,
+            cast<llvm::Constant>(Builder.CreateExtractValue(constant, i)),
+            IsAutoInit);
         }
         return;
-      }
     } else if (auto *ATy = dyn_cast<llvm::ArrayType>(Ty)) {
       // FIXME: handle the case when ATy != Loc.getElementType().
       if (ATy == Loc.getElementType()) {
diff --git a/clang/test/CodeGenCXX/auto-var-init.cpp b/clang/test/CodeGenCXX/auto-var-init.cpp
index 6cb18528ebadcdf..75a137f461b27d1 100644
--- a/clang/test/CodeGenCXX/auto-var-init.cpp
+++ b/clang/test/CodeGenCXX/auto-var-init.cpp
@@ -89,22 +89,14 @@ struct padded { char c; int i; };
 // PATTERN-O1-NOT: @__const.test_paddednullinit_custom.custom
 struct paddednullinit { char c = 0; int i = 0; };
 // PATTERN-O0: @__const.test_paddedpacked_uninit.uninit = private unnamed_addr constant %struct.paddedpacked <{ i8 [[I8]], i32 [[I32]] }>, align 1
-// PATTERN: @__const.test_paddedpacked_custom.custom = private unnamed_addr constant %struct.paddedpacked <{ i8 42, i32 13371337 }>, align 1
-// ZERO: @__const.test_paddedpacked_custom.custom = private unnamed_addr constant %struct.paddedpacked <{ i8 42, i32 13371337 }>, align 1
 struct paddedpacked { char c; int i; } __attribute__((packed));
 // PATTERN-O0: @__const.test_paddedpackedarray_uninit.uninit = private unnamed_addr constant %struct.paddedpackedarray { [2 x %struct.paddedpacked] [%struct.paddedpacked <{ i8 [[I8]], i32 [[I32]] }>, %struct.paddedpacked <{ i8 [[I8]], i32 [[I32]] }>] }, align 1
-// PATTERN: @__const.test_paddedpackedarray_custom.custom = private unnamed_addr constant %struct.paddedpackedarray { [2 x %struct.paddedpacked] [%struct.paddedpacked <{ i8 42, i32 13371337 }>, %struct.paddedpacked <{ i8 43, i32 13371338 }>] }, align 1
-// ZERO: @__const.test_paddedpackedarray_custom.custom = private unnamed_addr constant %struct.paddedpackedarray { [2 x %struct.paddedpacked] [%struct.paddedpacked <{ i8 42, i32 13371337 }>, %struct.paddedpacked <{ i8 43, i32 13371338 }>] }, align 1
 struct paddedpackedarray { struct paddedpacked p[2]; };
 // PATTERN-O0: @__const.test_unpackedinpacked_uninit.uninit = private unnamed_addr constant <{ { i8, [3 x i8], i32 }, i8 }> <{ { i8, [3 x i8], i32 } { i8 [[I8]], [3 x i8] c"\[[IC]]\[[IC]]\[[IC]]", i32 [[I32]] }, i8 [[I8]] }>, align 1
 struct unpackedinpacked { padded a; char b; } __attribute__((packed));
 // PATTERN-O0: @__const.test_paddednested_uninit.uninit = private unnamed_addr constant { { i8, [3 x i8], i32 }, { i8, [3 x i8], i32 } } { { i8, [3 x i8], i32 } { i8 [[I8]], [3 x i8] c"\[[IC]]\[[IC]]\[[IC]]", i32 [[I32]] }, { i8, [3 x i8], i32 } { i8 [[I8]], [3 x i8] c"\[[IC]]\[[IC]]\[[IC]]", i32 [[I32]] } }, align 4
-// PATTERN: @__const.test_paddednested_custom.custom = private unnamed_addr constant { { i8, [3 x i8], i32 }, { i8, [3 x i8], i32 } } { { i8, [3 x i8], i32 } { i8 42, [3 x i8] zeroinitializer, i32 13371337 }, { i8, [3 x i8], i32 } { i8 43, [3 x i8] zeroinitializer, i32 13371338 } }, align 4
-// ZERO: @__const.test_paddednested_custom.custom = private unnamed_addr constant { { i8, [3 x i8], i32 }, { i8, [3 x i8], i32 } } { { i8, [3 x i8], i32 } { i8 42, [3 x i8] zeroinitializer, i32 13371337 }, { i8, [3 x i8], i32 } { i8 43, [3 x i8] zeroinitializer, i32 13371338 } }, align 4
 struct paddednested { struct padded p1, p2; };
 // PATTERN-O0: @__const.test_paddedpackednested_uninit.uninit = private unnamed_addr constant %struct.paddedpackednested { %struct.paddedpacked <{ i8 [[I8]], i32 [[I32]] }>, %struct.paddedpacked <{ i8 [[I8]], i32 [[I32]] }> }, align 1
-// PATTERN: @__const.test_paddedpackednested_custom.custom = private unnamed_addr constant %struct.paddedpackednested { %struct.paddedpacked <{ i8 42, i32 13371337 }>, %struct.paddedpacked <{ i8 43, i32 13371338 }> }, align 1
-// ZERO: @__const.test_paddedpackednested_custom.custom = private unnamed_addr constant %struct.paddedpackednested { %struct.paddedpacked <{ i8 42, i32 13371337 }>, %struct.paddedpacked <{ i8 43, i32 13371338 }> }, align 1
 struct paddedpackednested { struct paddedpacked p1, p2; };
 // PATTERN-O0: @__const.test_bitfield_uninit.uninit = private unnamed_addr constant %struct.bitfield { i8 [[I8]], [3 x i8] c"\[[IC]]\[[IC]]\[[IC]]" }, align 4
 // PATTERN-O0: @__const.test_bitfield_custom.custom = private unnamed_addr constant %struct.bitfield { i8 20, [3 x i8] c"\[[IC]]\[[IC]]\[[IC]]" }, align 4
@@ -714,7 +706,8 @@ TEST_UNINIT(padded, padded);
 // CHECK-NEXT:  call void @{{.*}}used{{.*}}%uninit)
 // PATTERN-LABEL: @test_padded_uninit()
 // PATTERN-O0: call void @llvm.memcpy{{.*}} @__const.test_padded_uninit.uninit{{.+}}), !annotation [[AUTO_INIT]]
-// PATTERN-O1: store i64 [[I64]], ptr %uninit, align 8, !annotation [[AUTO_INIT]]
+// PATTERN-O1: store i64 [[I64]], ptr %uninit, align 8
+// PATTERN-O1-NOT:   !annotation
 // ZERO-LABEL: @test_padded_uninit()
 // ZERO-O0: call void @llvm.memset{{.*}}, i8 0,{{.+}}), !annotation [[AUTO_INIT]]
 // ZERO-O1: store i64 0, ptr %uninit, align 8, !annotation [[AUTO_INIT]]
@@ -740,7 +733,8 @@ TEST_UNINIT(paddednullinit, paddednullinit);
 // CHECK-NEXT:  call void @{{.*}}used{{.*}}%uninit)
 // PATTERN-LABEL: @test_paddednullinit_uninit()
 // PATTERN-O0: call void @llvm.memcpy{{.*}} @__const.test_paddednullinit_uninit.uninit{{.+}}), !annotation [[AUTO_INIT]]
-// PATTERN-O1: store i64 [[I64]], ptr %uninit, align 8, !annotation [[AUTO_INIT]]
+// PATTERN-O1: store i64 [[I64]], ptr %uninit, align 8
+// PATTERN-O1-NOT:   !annotation
 // ZERO-LABEL: @test_paddednullinit_uninit()
 // ZERO-O0: call void @llvm.memset{{.*}}, i8 0, {{.*}}, !annotation [[AUTO_INIT]]
 // ZERO-O1: store i64 0, ptr %uninit, align 8
@@ -778,9 +772,8 @@ TEST_UNINIT(paddedpacked, paddedpacked);
 // PATTERN-LABEL: @test_paddedpacked_uninit()
 // PATTERN-O0: call void @llvm.memcpy{{.*}} @__const.test_paddedpacked_uninit.uninit{{.+}}), !annotation [[AUTO_INIT]]
 // PATTERN-O1:  store i8 [[I8]], ptr %uninit, align {{.+}}, !annotation [[AUTO_INIT]]
-// PATTERN-O1:  %[[I:[^ ]*]] = getelementptr inbounds {{.*}}%uninit, i64 0, i32 1
+// PATTERN-O1:  %[[I:[^ ]*]] = getelementptr inbounds {{.*}}%uninit, i64 1
 // PATTERN-O1: store i32 [[I32]], ptr %[[I]], align {{.+}}, !annotation [[AUTO_INIT]]
-
 // ZERO-LABEL: @test_paddedpacked_uninit()
 // ZERO: call void @llvm.memset{{.*}}, i8 0,{{.+}}), !annotation [[AUTO_INIT]]
 
@@ -1192,7 +1185,8 @@ TEST_UNINIT(atomicpadded, _Atomic(padded));
 // CHECK-NEXT:  call void @{{.*}}used{{.*}}%uninit)
 // PATTERN-LABEL: @test_atomicpadded_uninit()
 // PATTERN-O0: call void @llvm.memcpy{{.*}} @__const.test_atomicpadded_uninit.uninit{{.+}}), !annotation [[AUTO_INIT]]
-// PATTERN-O1: store i64 [[IPTR]], ptr %uninit, align 8, !annotation [[AUTO_INIT]]
+// PATTERN-O1: store i64 [[IPTR]], ptr %uninit, align 8
+// PATTERN-O1-NOT: !annotation
 // ZERO-LABEL: @test_atomicpadded_uninit()
 // ZERO-O0: call void @llvm.memset{{.*}}, i8 0, {{.+}}), !annotation [[AUTO_INIT]]
 // ZERO-O1: store i64 0, ptr %uninit, align 8, !annotation [[AUTO_INIT]]
@@ -1214,8 +1208,7 @@ TEST_UNINIT(complexfloat, _Complex float);
 // PATTERN-LABEL: @test_complexfloat_uninit()
 // PATTERN-O0: call void @llvm.memcpy{{.*}} @__const.test_complexfloat_uninit.uninit{{.+}}), !annotation [[AUTO_INIT]]
 // PATTERN-O1: store float 0xFFFFFFFFE0000000, ptr %uninit, align {{.+}}, !annotation [[AUTO_INIT]]
-
-// PATTERN-O1:  %[[F2:[^ ]*]] = getelementptr inbounds {{.*}}%uninit, i64 0, i32 1
+// PATTERN-O1:  %[[F2:[^ ]*]] = getelementptr inbounds {{.*}}%uninit, i64 4
 // PATTERN-O1: store float 0xFFFFFFFFE0000000, ptr %[[F2]], align {{.+}}, !annotation [[AUTO_INIT]]
 
 // ZERO-LABEL: @test_complexfloat_uninit()
@@ -1314,7 +1307,9 @@ TEST_CUSTOM(semivolatile, semivolatile, { 0x44444444, 0x44444444 });
 // CHECK-O0:  call void @llvm.memcpy
 // CHECK-NOT:   !annotation
 // CHECK-O0:  call void @{{.*}}used{{.*}}%custom)
-// CHECK-O1:  store i64 4919131752989213764, ptr %custom, align 8
+// CHECK-O1:  store i32 1145324612, ptr %custom, align 4
+// CHECK-O1-NEXT:  %[[I:[^ ]*]] = getelementptr inbounds i8, ptr %custom, i64 4
+// CHECK-O1-NEXT:  store i32 1145324612, ptr %[[I]], align 4
 // CHECK-NOT:   !annotation
 
 TEST_UNINIT(semivolatileinit, semivolatileinit);
@@ -1427,7 +1422,7 @@ TEST_CUSTOM(matching, matching, { .f = 0xf00f });
 // CHECK-O0:  call void @llvm.memcpy
 // CHECK-NOT:   !annotation
 // CHECK-O0:  call void @{{.*}}used{{.*}}%custom)
-// CHECK-O1:  store i32 1198526208, ptr {{.*}}, align 4
+// CHECK-O1:  store float 6.145500e+04, ptr {{.*}}, align 4
 // CHECK-NOT:   !annotation
 
 TEST_UNINIT(matchingreverse, matchingreverse);
@@ -1506,8 +1501,12 @@ TEST_CUSTOM(unmatchedreverse, unmatchedreverse, { .c = 42  });
 // CHECK-O0:    call void @llvm.memcpy
 // CHECK-NOT:   !annotation
 // CHECK-O0:    call void @{{.*}}used{{.*}}%custom)
-// PATTERN-O1:  store i32 -1431655894, ptr {{.*}}, align 4
-// ZERO-O1:     store i32 42, ptr {{.*}}, align 4
+// PATTERN-O1:  store i8 42, ptr {{.*}}, align 4
+// PATTERN-O1-NEXT:  %[[I:[^ ]*]] = getelementptr inbounds i8, ptr %custom, i64 1
+// PATTERN-O1-NEXT:  call void @llvm.memset.{{.*}}({{.*}}, i8 -86, i64 3, {{.*}})
+// ZERO-O1:     store i8 42, ptr {{.*}}, align 4
+// ZERO-O1-NEXT:  %[[I:[^ ]*]] = getelementptr inbounds i8, ptr %custom, i64 1
+// ZERO-O1-NEXT:  call void @llvm.memset.{{.*}}({{.*}}, i8 0, i64 3, {{.*}})
 
 TEST_UNINIT(unmatchedfp, unmatchedfp);
 // CHECK-LABEL: @test_unmatchedfp_uninit()
@@ -1532,7 +1531,7 @@ TEST_CUSTOM(unmatchedfp, unmatchedfp, { .d = 3.1415926535897932384626433 });
 // CHECK-O0:    call void @llvm.memcpy
 // CHECK-NOT:   !annotation
 // CHECK-O0:    call void @{{.*}}used{{.*}}%custom)
-// CHECK-O1:    store i64 4614256656552045848, ptr %custom, align 8
+// CHECK-O1:    store double 0x400921FB54442D18, ptr %custom, align 8
 // CHECK-NOT:   !annotation
 
 TEST_UNINIT(emptyenum, emptyenum);

github-actions · 2023-11-08T14:23:46Z

✅ With the latest revision this PR passed the C/C++ code formatter.

…l-auto-var-init

…uto-var-init

clang/lib/CodeGen/CGDecl.cpp

…ivial-auto-var-init

clang/lib/CodeGen/CGDecl.cpp

efriedma-quic · 2023-11-09T21:32:39Z

clang/test/CodeGenCXX/auto-var-init.cpp

+// PATTERN-O1-NEXT:  %[[I:[^ ]*]] = getelementptr inbounds i8, ptr %custom, i64 2
+// PATTERN-O1-NEXT:  store i8 -86, ptr %[[I]], align {{.*}}
+// PATTERN-O1-NEXT:  %[[I:[^ ]*]] = getelementptr inbounds i8, ptr %custom, i64 3
+// PATTERN-O1-NEXT:  store i8 -86, ptr %[[I]], align {{.*}}


This doesn't look like an improvement... but I guess it's a general limitation of IR optimizations at the moment.

That's my feeling too.

…ivial-auto-var-init

serge-sans-paille · 2023-11-15T14:45:51Z

@efriedma-quic : gentle ping :-)

efriedma-quic

LGTM

omjavaid · 2023-11-23T07:43:09Z

This change appears to have broken several clang tests on following buildbots:
https://lab.llvm.org/buildbot/#/builders/245
https://lab.llvm.org/buildbot/#/builders/188
https://lab.llvm.org/buildbot/#/builders/186
https://lab.llvm.org/buildbot/#/builders/183

Kindly fix issues if they look trivial or revert the patch if more time is needed for the fix.

…-ftrivial-auto-var-init (#71677)" This reverts commit 0d2860b. This change appears to have broken several clang tests on following buildbots: https://lab.llvm.org/buildbot/#/builders/245 https://lab.llvm.org/buildbot/#/builders/188 https://lab.llvm.org/buildbot/#/builders/186 https://lab.llvm.org/buildbot/#/builders/183

serge-sans-paille · 2023-11-23T16:19:29Z

@omjavaid thanks for the revert. Life was in the way today and I couldn't handle that properly. The patch was trivial, I'm going to recommit soon.

…l-auto-var-init (#71677) Recommit of 0d2860b with extra test cases fixed.

JOE1994 · 2023-11-23T17:13:47Z

FYI, the following clang tests seem to fail after revision fe5c360

buildbot failure link : https://lab.llvm.org/buildbot/#/builders/245/builds/17047

Failed Tests (2):
  Clang :: CodeGen/aapcs-align.cpp
  Clang :: CodeGen/aapcs64-align.cpp

…-ftrivial-auto-var-init (#71677)" This reverts commit fe5c360. The commit causes the tests below to fail on many buildbots, e.g. https://lab.llvm.org/buildbot/#/builders/245/builds/17047 Clang :: CodeGen/aapcs-align.cpp Clang :: CodeGen/aapcs64-align.cpp

fhahn · 2023-11-23T20:24:59Z

Reverted the change for now, as many build bots have been red due to the test failures

fhahn · 2023-11-23T20:26:39Z

@serge-sans-paille those test failures were also highlighted by the precommit checks, would be good to check those before landing

…l-auto-var-init (llvm#71677) Recommit of 0d2860b with extra test cases fixed.

serge-sans-paille · 2023-11-24T13:43:36Z

@serge-sans-paille those test failures were also highlighted by the precommit checks, would be good to check those before landing

I did validate locally, but I forgot I had some targets disabled :-/

…l-auto-var-init (#71677) Recommit of 0d2860b with extra test cases fixed.

felipepiovezan · 2023-11-27T20:58:24Z

If this gets reverted for some reason, please note that I had to update a cross-project-tests test:
#73566

…-ftrivial-auto-var-init (llvm#71677)" This reverts commit afe8b93. Fixes: llvm#84178.

serge-sans-paille requested a review from jfbastien November 8, 2023 14:12

llvmbot added clang Clang issues not falling into any other category clang:codegen IR generation bugs: mangling, exceptions, etc. labels Nov 8, 2023

serge-sans-paille force-pushed the feature/trivial-auto-var-init-small-struct-padding branch 2 times, most recently from 7ebf51f to ee7c7d8 Compare November 8, 2023 14:40

serge-sans-paille added 2 commits November 8, 2023 15:48

[clang] Avoid memcopy for small structure with padding under -ftrivia…

d5934a4

…l-auto-var-init

[clang] Avoid memcopy for small arrays with padding under -ftrivial-a…

fcdfdbf

…uto-var-init

serge-sans-paille force-pushed the feature/trivial-auto-var-init-small-struct-padding branch from ee7c7d8 to fcdfdbf Compare November 8, 2023 14:49

serge-sans-paille changed the title ~~[clang] Avoid memcopy for small structure with padding~~ [clang] Avoid memcopy for small structure with padding under -ftrivial-auto-var-init Nov 8, 2023

efriedma-quic reviewed Nov 9, 2023

View reviewed changes

clang/lib/CodeGen/CGDecl.cpp Outdated Show resolved Hide resolved

fixup! [clang] Avoid memcopy for small arrays with padding under -ftr…

ef50031

…ivial-auto-var-init

efriedma-quic reviewed Nov 9, 2023

View reviewed changes

fixup! [clang] Avoid memcopy for small arrays with padding under -ftr…

fcb185e

…ivial-auto-var-init

efriedma-quic approved these changes Nov 21, 2023

View reviewed changes

serge-sans-paille merged commit 0d2860b into llvm:main Nov 23, 2023

serge-sans-paille added a commit that referenced this pull request Nov 23, 2023

[clang] Avoid memcopy for small structure with padding under -ftrivia…

fe5c360

…l-auto-var-init (#71677) Recommit of 0d2860b with extra test cases fixed.

serge-sans-paille added a commit to serge-sans-paille/llvm-project that referenced this pull request Nov 24, 2023

[clang] Avoid memcopy for small structure with padding under -ftrivia…

4af0f53

…l-auto-var-init (llvm#71677) Recommit of 0d2860b with extra test cases fixed.

serge-sans-paille added a commit that referenced this pull request Nov 24, 2023

[clang] Avoid memcopy for small structure with padding under -ftrivia…

afe8b93

…l-auto-var-init (#71677) Recommit of 0d2860b with extra test cases fixed.

antoniofrighetto added a commit to antoniofrighetto/llvm-project that referenced this pull request Mar 6, 2024

Revert "[clang] Avoid memcopy for small structure with padding under …

bb22ecc

…-ftrivial-auto-var-init (llvm#71677)" This reverts commit afe8b93. Fixes: llvm#84178.

antoniofrighetto mentioned this pull request Mar 6, 2024

[clang][CodeGen] Allow memcpy replace with trivial auto var init #84230

Merged

DimitryAndric mentioned this pull request Mar 20, 2024

c23 aggregate initialization #78034

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[clang] Avoid memcopy for small structure with padding under -ftrivial-auto-var-init #71677

[clang] Avoid memcopy for small structure with padding under -ftrivial-auto-var-init #71677

Uh oh!

serge-sans-paille commented Nov 8, 2023

Uh oh!

llvmbot commented Nov 8, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Nov 8, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

efriedma-quic Nov 9, 2023

Uh oh!

serge-sans-paille Nov 9, 2023

Uh oh!

serge-sans-paille commented Nov 15, 2023

Uh oh!

efriedma-quic left a comment

Uh oh!

omjavaid commented Nov 23, 2023

Uh oh!

serge-sans-paille commented Nov 23, 2023

Uh oh!

JOE1994 commented Nov 23, 2023 •

edited

Loading

Uh oh!

fhahn commented Nov 23, 2023

Uh oh!

fhahn commented Nov 23, 2023

Uh oh!

serge-sans-paille commented Nov 24, 2023

Uh oh!

felipepiovezan commented Nov 27, 2023

Uh oh!

Uh oh!

[clang] Avoid memcopy for small structure with padding under -ftrivial-auto-var-init #71677

[clang] Avoid memcopy for small structure with padding under -ftrivial-auto-var-init #71677

Uh oh!

Conversation

serge-sans-paille commented Nov 8, 2023

Uh oh!

llvmbot commented Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

efriedma-quic Nov 9, 2023

Choose a reason for hiding this comment

Uh oh!

serge-sans-paille Nov 9, 2023

Choose a reason for hiding this comment

Uh oh!

serge-sans-paille commented Nov 15, 2023

Uh oh!

efriedma-quic left a comment

Choose a reason for hiding this comment

Uh oh!

omjavaid commented Nov 23, 2023

Uh oh!

serge-sans-paille commented Nov 23, 2023

Uh oh!

JOE1994 commented Nov 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fhahn commented Nov 23, 2023

Uh oh!

fhahn commented Nov 23, 2023

Uh oh!

serge-sans-paille commented Nov 24, 2023

Uh oh!

felipepiovezan commented Nov 27, 2023

Uh oh!

Uh oh!

llvmbot commented Nov 8, 2023 •

edited

Loading

github-actions bot commented Nov 8, 2023 •

edited

Loading

JOE1994 commented Nov 23, 2023 •

edited

Loading