[cross-project-tests] Fix struct-dse example so that it fails again #73566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose of this example is to provide a case where the debugger / debug info experience could be improved. A recent commit by clang (0d2860b) changed codegen such that it changes how "small structs" are initialized, in a way that the debugger is now able to correctly display the variable being targeted by this test. In order to keep the example relevant, i.e. failing, this commit makes it so that the struct is now "big enough" to not trigger the new codegen.
|
This is to fix the greendragon test failures: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/63049/console |
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
adrian-prantl
approved these changes
Nov 27, 2023
|
Fix code formatting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this example is to provide a case where the debugger / debug info experience could be improved. A recent commit by clang (0d2860b) changed codegen such that it changes how "small structs" are initialized, in a way that the debugger is now able to correctly display the variable being targeted by this test.
In order to keep the example relevant, i.e. failing, this commit makes it so that the struct is now "big enough" to not trigger the new codegen.