Skip to content

[cross-project-tests] Fix struct-dse example so that it fails again #73566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

felipepiovezan
Copy link
Contributor

The purpose of this example is to provide a case where the debugger / debug info experience could be improved. A recent commit by clang (0d2860b) changed codegen such that it changes how "small structs" are initialized, in a way that the debugger is now able to correctly display the variable being targeted by this test.

In order to keep the example relevant, i.e. failing, this commit makes it so that the struct is now "big enough" to not trigger the new codegen.

The purpose of this example is to provide a case where the debugger / debug info
experience could be improved. A recent commit by clang
(0d2860b) changed codegen such that it changes
how "small structs" are initialized, in a way that the debugger is now able to
correctly display the variable being targeted by this test.

In order to keep the example relevant, i.e. failing, this commit makes it so
that the struct is now "big enough" to not trigger the new codegen.
@felipepiovezan
Copy link
Contributor Author

This is to fix the greendragon test failures: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/63049/console

Copy link

github-actions bot commented Nov 27, 2023

✅ With the latest revision this PR passed the C/C++ code formatter.

@felipepiovezan
Copy link
Contributor Author

Fix code formatting.

@felipepiovezan felipepiovezan merged commit a8837b4 into llvm:main Nov 27, 2023
@felipepiovezan felipepiovezan deleted the felipe/fixup_dexter_example branch November 27, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants