[Pass][NFC] Sort and format passes in PassRegistery.def

[paperchalice]

• Sort all passes in alphabetical order.
• Format llvm/lib/Passes/PassRegistry.def.
• Remove redundant semicolon.

[paperchalice]

CC @boomanaiden154

[boomanaiden154]

Thanks for looking into cleaning this up.

I didn't realize this would create so much churn when suggesting it. I think it would be good to have regardless, but curious what other reviewers think.

I also don't think we should be formatting the *_WITH_PARAMS macros as it seems to significantly hurt readability. Maybe wrap them in // clang-format off and // clang-format on so the file can be automatically formatted but without hurting readability?

[nikic]

LGTM

[nikic]

I also don't think we should be formatting the *_WITH_PARAMS macros as it seems to significantly hurt readability. Maybe wrap them in // clang-format off and // clang-format on so the file can be automatically formatted but without hurting readability?

The WITH_PARAMS formatting looks ok to me. We were lucky and this did not fall into the terrible "align to opening parentheses" heuristic.

[boomanaiden154]

The WITH_PARAMS formatting looks ok to me. We were lucky and this did not fall into the terrible "align to opening parentheses" heuristic.

Sounds good. No strong preference on my end. It's a little bit less consistent, but still easy enough to figure out what's going on.

[paperchalice]

If it looks good, could someone merge this? I don't have write access. Thanks!

[boomanaiden154]

If it looks good, could someone merge this? I don't have write access. Thanks!

I can do it. Side note: Now that you've landed a couple patches, you can probably email Chris and request commit access (https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access).