[-Wunsafe-buffer-usage] Fix AST matcher of UUCAddAssignGadget

[jkorous-apple]

We are not interested in nonpointers being added to.

[llvmbot]

@llvm/pr-subscribers-clang

@llvm/pr-subscribers-clang-analysis

Author: None (jkorous-apple)

Changes

We are not interested in nonpointers being added to.

---

Full diff: https://github.com/llvm/llvm-project/pull/79392.diff

1 Files Affected:

• (modified) clang/lib/Analysis/UnsafeBufferUsage.cpp (+6-1)

diff --git a/clang/lib/Analysis/UnsafeBufferUsage.cpp b/clang/lib/Analysis/UnsafeBufferUsage.cpp
index 7df706beb22662c..fd7a76d511862ec 100644
--- a/clang/lib/Analysis/UnsafeBufferUsage.cpp
+++ b/clang/lib/Analysis/UnsafeBufferUsage.cpp
@@ -1081,11 +1081,16 @@ class UUCAddAssignGadget : public FixableGadget {
   }
 
   static Matcher matcher() {
+// clang-format off
     return stmt(isInUnspecifiedUntypedContext(expr(ignoringImpCasts(
         binaryOperator(hasOperatorName("+="),
-                       hasLHS(declRefExpr(toSupportedVariable())),
+                       hasLHS(
+                        declRefExpr(
+                          hasPointerType(),
+                          toSupportedVariable())),
                        hasRHS(expr().bind(OffsetTag)))
             .bind(UUCAddAssignTag)))));
+// clang-format on
   }
 
   virtual std::optional<FixItList> getFixits(const Strategy &S) const override;

[github-actions]

✅ With the latest revision this PR passed the C/C++ code formatter.

[jkorous-apple]

Buildkite failed for unrelated reason - this change really doesn't introduce virus in filecheck on Windows.

# executed command: 'c:\ws\src\build\build-clang-windows\bin\filecheck.exe' -check-prefix=CHECK-CC1 'C:\ws\src\clang\test\CodeCompletion\using.cpp'
--
  | # .---command stderr------------
  | # \| Could not create process (c:\ws\src\build\build-clang-windows\bin\filecheck.exe) due to [WinError 225] Operation did not complete successfully because the file contains a virus or potentially unwanted software

[ziqingluo-90]

LGTM, It's great to catch and fix this bug!