Skip to content

[-Wunsafe-buffer-usage] Fix AST matcher of UUCAddAssignGadget #79392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 30, 2024
Merged

[-Wunsafe-buffer-usage] Fix AST matcher of UUCAddAssignGadget #79392

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcc2b0c
[-Wunsafe-buffer-usage] Fix AST matcher of UUCAddAssignGadget
jkorous-apple Jan 24, 2024
422d98b
Merge branch 'main' into cxx-safe-buffers/fix-nonptr-assign-to-matcher
jkorous-apple Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion clang/lib/Analysis/UnsafeBufferUsage.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1081,11 +1081,16 @@ class UUCAddAssignGadget : public FixableGadget {
}

static Matcher matcher() {
// clang-format off
return stmt(isInUnspecifiedUntypedContext(expr(ignoringImpCasts(
binaryOperator(hasOperatorName("+="),
hasLHS(declRefExpr(toSupportedVariable())),
hasLHS(
declRefExpr(
hasPointerType(),
toSupportedVariable())),
hasRHS(expr().bind(OffsetTag)))
.bind(UUCAddAssignTag)))));
// clang-format on
}

virtual std::optional<FixItList> getFixits(const Strategy &S) const override;
Expand Down