[lldb] python-bindings: fix SBTarget.get_target_watchpoints()

[nikitalita]

Fixes erroneous usage of bkpts instead of watchpoints (probably introduced from copying and pasting get_target_bkpts()).

[llvmbot]

@llvm/pr-subscribers-lldb

Author: None (nikitalita)

Changes

Fixes erroneous usage of bkpts instead of watchpoints (probably introduced from copying and pasting get_target_bkpts()).

---

Full diff: https://github.com/llvm/llvm-project/pull/82295.diff

1 Files Affected:

• (modified) lldb/bindings/interface/SBTargetExtensions.i (+1-1)

diff --git a/lldb/bindings/interface/SBTargetExtensions.i b/lldb/bindings/interface/SBTargetExtensions.i
index c80dadfc0c5ca5..d756a351a810ab 100644
--- a/lldb/bindings/interface/SBTargetExtensions.i
+++ b/lldb/bindings/interface/SBTargetExtensions.i
@@ -172,7 +172,7 @@ STRING_EXTENSION_LEVEL_OUTSIDE(SBTarget, lldb::eDescriptionLevelBrief)
             '''An accessor function that returns a list() that contains all watchpoints in a lldb.SBtarget object.'''
             watchpoints = []
             for idx in range(self.GetNumWatchpoints()):
-                bkpts.append(self.GetWatchpointAtIndex(idx))
+                watchpoints.append(self.GetWatchpointAtIndex(idx))
             return watchpoints
 
         modules = property(get_modules_array, None, doc='''A read only property that returns a list() of lldb.SBModule objects contained in this target. This list is a list all modules that the target currently is tracking (the main executable and all dependent shared libraries).''')

[github-actions]

⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo.
Please turn off Keep my email addresses private setting in your account.
See LLVM Discourse for more information.

[jimingham]

LGTM

[JDevlieghere]

LGTM. Let me know if you need someone to land this for you (and if you want to set your e-mail address to public before that).

[nikitalita]

LGTM. Let me know if you need someone to land this for you

I do need someone to land this for me. People keep asking me that on this repo; Is there a way for me to apply for write access or something?

(and if you want to set your e-mail address to public before that).

I don’t want to get an inbox full of spam, so I’d rather not.

[JDevlieghere]

LGTM. Let me know if you need someone to land this for you

I do need someone to land this for me. People keep asking me that; Is there a way for me to apply for write access or something?

https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

(and if you want to set your e-mail address to public before that).
I don’t want to get an inbox full of spam, so I’d rather not.

That's fair, though that means that you will not get notifications when bots fail so you'll need to actively monitor them yourself.