[DebugInfo][ObjectYAML] Remove duplicate "Flags" field from LabelSym

[nikitalita]

There was a duplicate flags field mistakenly left in LabelSym. LabelSym only has one flags field

[llvmbot]

@llvm/pr-subscribers-objectyaml

Author: None (nikitalita)

Changes

There was a duplicate flags field mistakenly left in LabelSym. [LabelSym only has one flags field](https://github.com/microsoft/microsoft-pdb/blob/805655a28bd8198004be2ac27e6e0290121a5e89/include/cvinfo.h#L3806

---

Full diff: https://github.com/llvm/llvm-project/pull/88194.diff

1 Files Affected:

• (modified) llvm/lib/ObjectYAML/CodeViewYAMLSymbols.cpp (-1)

diff --git a/llvm/lib/ObjectYAML/CodeViewYAMLSymbols.cpp b/llvm/lib/ObjectYAML/CodeViewYAMLSymbols.cpp
index 64e1a58aa71a8a..e1d2700623ec3c 100644
--- a/llvm/lib/ObjectYAML/CodeViewYAMLSymbols.cpp
+++ b/llvm/lib/ObjectYAML/CodeViewYAMLSymbols.cpp
@@ -467,7 +467,6 @@ template <> void SymbolRecordImpl<LabelSym>::map(IO &IO) {
   IO.mapOptional("Offset", Symbol.CodeOffset, 0U);
   IO.mapOptional("Segment", Symbol.Segment, uint16_t(0));
   IO.mapRequired("Flags", Symbol.Flags);
-  IO.mapRequired("Flags", Symbol.Flags);
   IO.mapRequired("DisplayName", Symbol.Name);
 }
 

[github-actions]

⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo.
Please turn off Keep my email addresses private setting in your account.
See LLVM Discourse for more information.

[jh7370]

LGTM, but please see the warning from the bot about your email address.

[nikitalita]

I'd rather not use my real e-mail, as I don't want to get a bunch of spam

[jh7370]

I'd rather not use my real e-mail, as I don't want to get a bunch of spam

It is my understanding that LLVM has a policy of no GitHub noreply emails; there are many reasons why. Please see the Discourse thread on this topic.

[nikitalita]

Wasn't a problem last time.

[jh7370]

Wasn't a problem last time.

Thanks for pointing that out. I think my comment still stands, as the broad consensus (admittedly not unanimous) was that people should have public emails in the repository. It's quite possible @JDevlieghere wasn't aware of the thread. Please read the thread if you haven't already. I'll also post there to raise this again to try and understand where the consensus actually is and raise these two PRs as an example.

On the note of spam, at least two separate users reported getting very few spam emails that could be traced to their github emails (in one case, less than 30 a month, all filtered by gmail correctly). I personally can't comment because a) I rarely directly commit anymore, and b) I have a company email address, so I expect the company's spam filters filter things out without me ever seeing them.

[nikitalita]

Ok, I have made my email address public

[jh7370]

Ok, I have made my email address public

Thank you! Do you have commit access yet?

[nikitalita]

I do not, so you will have to push the button for me.

[jh7370]

Done. Please keep an eye out for emails from the build bots indicating failures that might be related to your change.

Also, my apologies if you get a sudden influx of spam!