Skip to content

Removed redundant template in '__delete_node()' member function of '__forward_list_base' and '__list_imp' classes. #84323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2024
Merged

Removed redundant template in '__delete_node()' member function of '__forward_list_base' and '__list_imp' classes. #84323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28d3f04
the variadic template 'template <class... Args>' has been removed fro…
Mar 7, 2024
74d88d0
Merge branch 'llvm:main' into main
2LoS Mar 7, 2024
a9e0e00
Merge branch 'llvm:main' into main
Apr 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion libcxx/include/forward_list
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,7 +554,6 @@ protected:
return __guard.__release_ptr();
}

template <class... _Args>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why this was here in the first place?
Were we trying to get around some type-incompleteness?

Could you please make sure we have sufficient tests for the allocator incompleteness requirements?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is from #65614, which looks like it's just copy-pasted. Checking test coverage would be good though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EricWF, could you help me to land this PR, please?

_LIBCPP_HIDE_FROM_ABI void __delete_node(__node_pointer __node) {
// For the same reason as above, we use the allocator's destroy() method for the value_type,
// but not for the node itself.
Expand Down
1 change: 0 additions & 1 deletion libcxx/include/list
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,7 +567,6 @@ protected:
return __guard.__release_ptr();
}

template <class... _Args>
_LIBCPP_HIDE_FROM_ABI void __delete_node(__node_pointer __node) {
// For the same reason as above, we use the allocator's destroy() method for the value_type,
// but not for the node itself.
Expand Down