[libc++] Add <locale> include in <chrono> #85521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Nikolas Klauser (philnik777) ChangesI accidentally removed this transitive include in #85478. Full diff: https://github.com/llvm/llvm-project/pull/85521.diff 2 Files Affected:
diff --git a/libcxx/include/chrono b/libcxx/include/chrono
index 0320c1dc4c2f96..5bab3f8ad5cf05 100644
--- a/libcxx/include/chrono
+++ b/libcxx/include/chrono
@@ -883,6 +883,7 @@ constexpr chrono::year operator ""y(unsigned lo
#if !defined(_LIBCPP_REMOVE_TRANSITIVE_INCLUDES) && _LIBCPP_STD_VER == 20
# include <charconv>
+# include <locale>
#endif
#endif // _LIBCPP_CHRONO
diff --git a/libcxx/test/libcxx/transitive_includes/cxx20.csv b/libcxx/test/libcxx/transitive_includes/cxx20.csv
index b355e7b0338b9f..03b4eda8b4d868 100644
--- a/libcxx/test/libcxx/transitive_includes/cxx20.csv
+++ b/libcxx/test/libcxx/transitive_includes/cxx20.csv
@@ -128,6 +128,7 @@ chrono ctime
chrono cwchar
chrono forward_list
chrono limits
+chrono locale
chrono optional
chrono ostream
chrono ratio
|
|
The CI failure is unrelated. |
blueboxd
pushed a commit
to blueboxd/libcxx
that referenced
this pull request
Apr 19, 2025
…ro (#97869) This is a follow-up to llvm/llvm-project#85521, similar to llvm/llvm-project#95686. NOKEYCHECK=True GitOrigin-RevId: 5789ee28772d942da113762f45fa5f47996b55d7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally removed this transitive include in #85478.