[libc++] Guard transitive include of <locale> with availability macro
#95686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to llvm#80282. The transitive includes of `<locale>` in `<vector>` were all guarded by the availability macro -- the new include should also be guarded, otherwise any users who compile with localization disabled will start getting errors trying to include `<vector>`.
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Konstantin Varlamov (var-const) ChangesThis is a follow-up to #80282. Full diff: https://github.com/llvm/llvm-project/pull/95686.diff 1 Files Affected:
diff --git a/libcxx/include/vector b/libcxx/include/vector
index cbfc2cefa1fd9..c2f541d3fcdb7 100644
--- a/libcxx/include/vector
+++ b/libcxx/include/vector
@@ -2974,7 +2974,9 @@ _LIBCPP_POP_MACROS
# include <concepts>
# include <cstdlib>
# include <iosfwd>
+#if !defined(_LIBCPP_HAS_NO_LOCALIZATION)
# include <locale>
+#endif
# include <tuple>
# include <type_traits>
# include <typeinfo>
|
|
LGTM, CI failure is unrelated. |
ldionne
approved these changes
Jun 17, 2024
var-const
added a commit
to var-const/llvm-project
that referenced
this pull request
Jul 17, 2024
This is a follow-up to llvm#85478, similar to llvm#95686.
blueboxd
pushed a commit
to blueboxd/libcxx
that referenced
this pull request
Apr 19, 2025
…ro (#97869) This is a follow-up to llvm/llvm-project#85521, similar to llvm/llvm-project#95686. NOKEYCHECK=True GitOrigin-RevId: 5789ee28772d942da113762f45fa5f47996b55d7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #80282.
The transitive includes of
<locale>in<vector>were all guarded bythe availability macro -- the new include should also be guarded,
otherwise any users who compile with localization disabled will start
getting errors trying to include
<vector>.