[Clang][Sema] placement new initializes typedef array with correct size #88902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-clang Author: None (mahtohappy) ChangesBuild Failure Fix Full diff: https://github.com/llvm/llvm-project/pull/88902.diff 1 Files Affected:
diff --git a/clang/test/SemaCXX/instantiate-new-placement-size.cpp b/clang/test/SemaCXX/PR41441.cpp
similarity index 95%
rename from clang/test/SemaCXX/instantiate-new-placement-size.cpp
rename to clang/test/SemaCXX/PR41441.cpp
index 7a29d3dee8491e..ecc8594dfff67a 100644
--- a/clang/test/SemaCXX/instantiate-new-placement-size.cpp
+++ b/clang/test/SemaCXX/PR41441.cpp
@@ -1,5 +1,5 @@
// RUN: %clang -S -fno-discard-value-names -emit-llvm -o - %s | FileCheck %s
-// Issue no: 41441
+
#include <new>
// CHECK: call void @llvm.memset.p0.i64(ptr align 1 %x, i8 0, i64 8, i1 false)
|
erichkeane
approved these changes
Apr 16, 2024
| // RUN: %clang -S -fno-discard-value-names -emit-llvm -o - %s | FileCheck %s | ||
| // Issue no: 41441 | ||
| // RUN: %clang --target=x86_64-pc-linux -S -fno-discard-value-names -emit-llvm -o - %s | FileCheck %s | ||
|
|
||
| #include <new> |
There was a problem hiding this comment.
This #include is also possible to cause breakages, you should just put hte important declarations in text.
There was a problem hiding this comment.
It does:
https://lab.llvm.org/buildbot/#/builders/280/builds/1989
/Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/clang/test/SemaCXX/PR41441.cpp:3:10: fatal error: 'new' file not found
3 | #include <new>
| ^~~~~
1 error generated.
There was a problem hiding this comment.
Blarg, the buildbots i checked on were mangling differences. I'll fix this locally as I suggested and get a fix merged ASAP.
There was a problem hiding this comment.
Should be good as of 0a789ea
erichkeane
added a commit
that referenced
this pull request
Apr 16, 2024
This just replaces an '#include<new>' with a declaration of array placement new.
metaflow
added a commit
that referenced
this pull request
Apr 17, 2024
mahtohappy
added a commit
to mahtohappy/llvm-project
that referenced
this pull request
Apr 17, 2024
…ze (llvm#88902) Build Failure Fix Fixes build failures due to llvm#83124
mahtohappy
pushed a commit
to mahtohappy/llvm-project
that referenced
this pull request
Apr 17, 2024
This just replaces an '#include<new>' with a declaration of array placement new.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build Failure Fix
Fixes build failures due to #83124